[ET-VK] Modifying should_squeeze function in SqueezeUnsqueezeInputs to not squeeze if significant axis are all 1 and trailing axis are all > 1.

This diff modifies the `should_squeeze` function in `SqueezeUnsqueezeInputs` to not squeeze (return False) if significant axes are all 1 and trailing axes are all > 1.

Differential Revision: [D75483587](https://our.internmc.facebook.com/intern/diff/D75483587/)

[ghstack-poisoned]

Author: trivedivivek

backends/vulkan/_passes/squeeze_unsqueeze_inputs.py

@@ -32,7 +32,13 @@ def should_squeeze(self, op, shape: List[int]) -> bool:  # pyre-ignore
             return shape[1] == 1 and shape[0] > 1
         if len(shape) == 4:
             # No need to squeeze if all dims are 1 except the width dim
-            if all(dim == 1 for dim in shape[:-1]):
+            if shape[0] == shape[1] == shape[2] == 1:
+                return False
+            # No need to squeeze if batch and channel dims are 1 and height and width are > 1
+            if shape[0] == shape[1] == 1 and shape[2] > 1 and shape[3] > 1:
+                return False
+            # No need to squeeze if batch dim is 1 and channel, height and width are > 1
+            if shape[0] == 1 and shape[1] > 1 and shape[2] > 1 and shape[3] > 1:
                 return False
             # Otherwise, check for squeezable dim
             return 1 in shape[:-1]

backends/vulkan/vulkan_preprocess.py

@@ -150,14 +150,14 @@ def preprocess(  # noqa: C901
         program = apply_passes(
             program,
             [
-                RemoveRedundantOpsTransform(),
                 AddmmToLinearTransform(),
                 FuseQuantizedOpsTransform(program),
                 SqueezeUnsqueezeInputs(),
                 FuseViewCopyTransform(),
                 ViewCopyToSqueezeUnsqueezePass(),
                 FuseBatchNormWithConvPass(program),
                 FuseClampPass(),
+                RemoveRedundantOpsTransform(),
             ],
         )