Cleanup to include error handling and debug code removal

Author: BujSet

codegen/tools/gen_selected_op_variants.py

@@ -70,7 +70,6 @@
 
 
 def write_selected_op_variants(yaml_file_path: str, output_dir: str) -> None:
-    print("REMOVE_ME: yaml_file_path is: " + str(yaml_file_path))
     with open(yaml_file_path, "r") as selected_operators_file:
         # Collect et_kernel_metadata from selected_operators.yaml and extract dtypes
         # Example format: v1/6;0,1|6;0,1|6;0,1|6;0,1  # Float, 0, 1
@@ -127,7 +126,6 @@ def main(argv: List[Any]) -> None:
     )
 
     options = parser.parse_args(argv)
-    print("REMOVE_ME: output dir was set to" + str(options.output_dir))
     write_selected_op_variants(options.yaml_file_path, options.output_dir)
 
 

selected_op_variants_add_mul.h

@@ -15,15 +15,15 @@ EXTRA_BUILD_ARGS="${@:-}"
 # TODO(#8357): Remove -Wno-int-in-bool-context
 # TODO: Replace -ET_HAVE_PREAD=0 with a CMake option.
 #  FileDataLoader used in the size_test breaks baremetal builds with pread when missing.
-COMMON_CXXFLAGS="-fno-exceptions -fno-rtti -Wall -Wno-int-in-bool-context -DET_HAVE_PREAD=0"
+COMMON_CXXFLAGS="-fno-exceptions -fno-rtti -Wall -Werror -Wno-int-in-bool-context -DET_HAVE_PREAD=0"
 
 cmake_install_executorch_lib() {
   echo "Installing libexecutorch.a"
   clean_executorch_install_folders
   update_tokenizers_git_submodule
   local EXTRA_BUILD_ARGS="${@}"
 
-  CXXFLAGS="$COMMON_CXXFLAGS" retry cmake \
+  CXXFLAGS="$COMMON_CXXFLAGS" retry cmake -DBUCK2="$BUCK2" \
           -DCMAKE_CXX_STANDARD_REQUIRED=ON \
           -DCMAKE_INSTALL_PREFIX=cmake-out \
           -DCMAKE_BUILD_TYPE=Release \
@@ -44,9 +44,11 @@ test_cmake_size_test() {
     echo "Build size test"
     cmake --build cmake-out/test -j9 --config Release
 
-    #cmake-out/test/size_test
-    #cmake-out/test/size_test_all_ops
-    ls -lah cmake-out/test/
+    echo 'ExecuTorch with no ops binary size, unstripped:'
+    ls -al cmake-out/test/size_test
+
+    echo 'ExecuTorch with portable ops binary size, unstripped:'
+    ls -al cmake-out/test/size_test_all_ops
 }
 
 if [[ -z $PYTHON_EXECUTABLE ]]; then

test/build_size_test.sh

@@ -22,8 +22,9 @@ function(gen_selected_ops)
   message(STATUS "  INCLUDE_ALL_OPS: ${GEN_INCLUDE_ALL_OPS}")
   message(STATUS "  OPS_FROM_MODEL: ${GEN_OPS_FROM_MODEL}")
   message(STATUS "  DTYPE_SELECTIVE_BUILD: ${GEN_DTYPE_SELECTIVE_BUILD}")
-  if(GEN_DTYPE_SELECTIVE_BUILD)
-     message(STATUS "  DTYPE_SELECTIVE_BUILD is still WIP and may not be fully functional")
+
+  if(GEN_DTYPE_SELECTIVE_BUILD AND NOT GEN_OPS_FROM_MODEL)
+     message(FATAL_ERROR "  DTYPE_SELECTIVE_BUILD is only support with model API, please pass in a model")
   endif()
 
   set(_oplist_yaml
@@ -71,7 +72,6 @@ function(gen_selected_ops)
                           --output-dir=${CMAKE_CURRENT_BINARY_DIR}/${GEN_LIB_NAME}/
     )
     message("Command - ${_gen_opvariant_command}")
-    message("OUTPUT - ${_opvariant_h}")
     add_custom_command(
       COMMENT "Generating ${_opvariant_h} for ${GEN_LIB_NAME}"
       OUTPUT ${_opvariant_h}
@@ -274,10 +274,8 @@ function(gen_operators_lib)
       target_link_libraries(${GEN_LIB_NAME} PUBLIC selected_portable_kernels)
     endif()
 
-    # portable_kernel is no longer in GEN_KERNEL_LIBS, but there may be others
     if(GEN_KERNEL_LIBS)
-
-      target_link_libraries(${GEN_LIB_NAME} PUBLIC ${GEN_KERNEL_LIBS})
+      message(FATAL_ERROR "Currently dtype selective build is only supported for portable_kernels but {${GEN_KERNEL_LIBS}} were provided!")
     endif()
   endif()