Skip to content

Commit b28b73e

Browse files
GregoryComerGregoryComer
authored
[executorch] Remove EXECUTORCH_CLIENTS visibility gating - XNNPACK & Vulkan Backends
Differential Revision: D89902028 Pull Request resolved: #16477
1 parent 029874c commit b28b73e

File tree

13 files changed

+28
-122
lines changed

13 files changed

+28
-122
lines changed

‎backends/vulkan/partitioner/TARGETS‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@ runtime.python_library(
77
srcs = [
88
"vulkan_partitioner.py",
99
],
10-
visibility = [
11-
"//executorch/...",
12-
"@EXECUTORCH_CLIENTS",
13-
],
10+
visibility = ["PUBLIC"],
1411
deps = [
1512
"//executorch/backends/vulkan:op_registry",
1613
"//executorch/backends/vulkan:utils_lib",

‎backends/vulkan/serialization/targets.bzl‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,11 +47,7 @@ def define_common_targets(is_fbcode = False):
4747
resources = [
4848
"schema.fbs",
4949
],
50-
visibility = [
51-
"//executorch/...",
52-
"//executorch/vulkan/...",
53-
"@EXECUTORCH_CLIENTS",
54-
],
50+
visibility = ["PUBLIC"],
5551
deps = [
5652
"//executorch/exir:graph_module",
5753
"//executorch/exir/_serialize:_bindings",

‎backends/vulkan/targets.bzl‎

Lines changed: 7 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -158,10 +158,7 @@ def define_common_targets(is_fbcode = False):
158158
runtime.python_binary(
159159
name = "gen_vulkan_spv_bin",
160160
main_module = "runtime.gen_vulkan_spv",
161-
visibility = [
162-
"//executorch/backends/vulkan/...",
163-
"@EXECUTORCH_CLIENTS",
164-
],
161+
visibility = ["PUBLIC"],
165162
deps = [
166163
":gen_vulkan_spv_lib",
167164
],
@@ -241,10 +238,7 @@ def define_common_targets(is_fbcode = False):
241238
]),
242239
labels = get_labels(no_volk),
243240
platforms = get_platforms(),
244-
visibility = [
245-
"//executorch/backends/vulkan/...",
246-
"@EXECUTORCH_CLIENTS",
247-
],
241+
visibility = ["PUBLIC"],
248242
fbobjc_frameworks = select({
249243
"DEFAULT": [],
250244
"ovr_config//os:macos": [
@@ -270,12 +264,7 @@ def define_common_targets(is_fbcode = False):
270264
]),
271265
labels = get_labels(no_volk),
272266
platforms = get_platforms(),
273-
visibility = [
274-
"//executorch/backends/...",
275-
"//executorch/extension/pybindings/...",
276-
"//executorch/test/...",
277-
"@EXECUTORCH_CLIENTS",
278-
],
267+
visibility = ["PUBLIC"],
279268
exported_deps = [
280269
":vulkan_graph_runtime_shaderlib{}".format(suffix),
281270
"//executorch/runtime/backend:interface",
@@ -309,12 +298,7 @@ def define_common_targets(is_fbcode = False):
309298
]),
310299
labels = get_labels(no_volk),
311300
platforms = get_platforms(),
312-
visibility = [
313-
"//executorch/backends/...",
314-
"//executorch/extension/pybindings/...",
315-
"//executorch/test/...",
316-
"@EXECUTORCH_CLIENTS",
317-
],
301+
visibility = ["PUBLIC"],
318302
deps = [
319303
":vulkan_graph_runtime{}".format(suffix),
320304
"//executorch/backends/vulkan/serialization:vk_delegate_schema",
@@ -353,11 +337,7 @@ def define_common_targets(is_fbcode = False):
353337
srcs = [
354338
"custom_ops_lib.py"
355339
],
356-
visibility = [
357-
"//executorch/...",
358-
"//executorch/vulkan/...",
359-
"@EXECUTORCH_CLIENTS",
360-
],
340+
visibility = ["PUBLIC"],
361341
deps = [
362342
"//caffe2:torch",
363343
"//executorch/backends/vulkan/patterns:vulkan_patterns",
@@ -369,11 +349,7 @@ def define_common_targets(is_fbcode = False):
369349
srcs = [
370350
"op_registry.py",
371351
],
372-
visibility = [
373-
"//executorch/...",
374-
"//executorch/vulkan/...",
375-
"@EXECUTORCH_CLIENTS",
376-
],
352+
visibility = ["PUBLIC"],
377353
deps = [
378354
":custom_ops_lib",
379355
":utils_lib",
@@ -388,11 +364,7 @@ def define_common_targets(is_fbcode = False):
388364
srcs = [
389365
"vulkan_preprocess.py",
390366
],
391-
visibility = [
392-
"//executorch/...",
393-
"//executorch/vulkan/...",
394-
"@EXECUTORCH_CLIENTS",
395-
],
367+
visibility = ["PUBLIC"],
396368
deps = [
397369
"//executorch/backends/transforms:addmm_mm_to_linear",
398370
"//executorch/backends/transforms:fuse_batch_norm_with_conv",

‎backends/vulkan/test/custom_ops/targets.bzl‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,7 @@ def define_common_targets(is_fbcode = False):
3838
"glsl/*.glsl",
3939
"glsl/*.yaml",
4040
]),
41-
visibility = [
42-
"//executorch/backends/vulkan/test/custom_ops/...",
43-
"@EXECUTORCH_CLIENTS",
44-
],
41+
visibility = ["PUBLIC"],
4542
)
4643

4744
vulkan_spv_shader_lib(
@@ -71,10 +68,7 @@ def define_common_targets(is_fbcode = False):
7168
deps = [
7269
"//executorch/backends/vulkan:vulkan_graph_runtime",
7370
],
74-
visibility = [
75-
"//executorch/backends/vulkan/test/custom_ops/...",
76-
"@EXECUTORCH_CLIENTS",
77-
],
71+
visibility = ["PUBLIC"],
7872
)
7973

8074
# Operator implementations library
@@ -88,10 +82,7 @@ def define_common_targets(is_fbcode = False):
8882
"//executorch/backends/vulkan:vulkan_graph_runtime",
8983
":custom_ops_shaderlib",
9084
],
91-
visibility = [
92-
"//executorch/backends/vulkan/test/custom_ops/...",
93-
"@EXECUTORCH_CLIENTS",
94-
],
85+
visibility = ["PUBLIC"],
9586
link_whole = True,
9687
)
9788

‎backends/vulkan/test/op_tests/targets.bzl‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -158,10 +158,7 @@ def define_common_targets(is_fbcode = False):
158158
"//executorch/runtime/core/exec_aten:lib",
159159
runtime.external_dep_location("libtorch"),
160160
],
161-
visibility = [
162-
"//executorch/backends/vulkan/test/op_tests/...",
163-
"@EXECUTORCH_CLIENTS",
164-
],
161+
visibility = ["PUBLIC"],
165162
)
166163

167164
define_test_targets(

‎backends/xnnpack/TARGETS‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ runtime.python_library(
1010
srcs = [
1111
"xnnpack_preprocess.py",
1212
],
13-
visibility = [
14-
"//executorch/...",
15-
"@EXECUTORCH_CLIENTS",
16-
],
13+
visibility = ["PUBLIC"],
1714
deps = [
1815
"//executorch/backends/transforms:lib",
1916
"//executorch/backends/transforms:remove_getitem_op",
@@ -30,10 +27,7 @@ runtime.python_library(
3027
srcs = [
3128
"__init__.py",
3229
],
33-
visibility = [
34-
"//executorch/...",
35-
"@EXECUTORCH_CLIENTS",
36-
],
30+
visibility = ["PUBLIC"],
3731
deps = [
3832
":xnnpack_preprocess",
3933
"//executorch/backends/xnnpack/partition:xnnpack_partitioner",

‎backends/xnnpack/operators/TARGETS‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,7 @@ oncall("executorch")
55
runtime.python_library(
66
name = "operators",
77
srcs = glob(["*.py"]),
8-
visibility = [
9-
"//executorch/...",
10-
"@EXECUTORCH_CLIENTS",
11-
],
8+
visibility = ["PUBLIC"],
129
deps = [
1310
"//executorch/backends/xnnpack/utils:xnnpack_utils",
1411
"//executorch/exir:graph_module",

‎backends/xnnpack/partition/TARGETS‎

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@ runtime.python_library(
77
srcs = [
88
"xnnpack_partitioner.py",
99
],
10-
visibility = [
11-
"//executorch/...",
12-
"@EXECUTORCH_CLIENTS",
13-
],
10+
visibility = ["PUBLIC"],
1411
deps = [
1512
":partitioner_graphs",
1613
"//executorch/backends/xnnpack:xnnpack_preprocess",
@@ -28,10 +25,7 @@ runtime.python_library(
2825
srcs = glob([
2926
"graphs/*.py",
3027
]),
31-
visibility = [
32-
"//executorch/...",
33-
"@EXECUTORCH_CLIENTS",
34-
],
28+
visibility = ["PUBLIC"],
3529
deps = [
3630
"//executorch/exir:lib",
3731
],

‎backends/xnnpack/partition/config/TARGETS‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@ runtime.python_library(
77
srcs = glob([
88
"*.py",
99
]),
10-
visibility = [
11-
"//executorch/...",
12-
"@EXECUTORCH_CLIENTS",
13-
],
10+
visibility = ["PUBLIC"],
1411
deps = [
1512
"//executorch/exir:lib",
1613
"//executorch/exir/backend:partitioner",

‎backends/xnnpack/recipes/TARGETS‎

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,7 @@ runtime.python_library(
77
srcs = [
88
"__init__.py",
99
],
10-
visibility = [
11-
"//executorch/...",
12-
"@EXECUTORCH_CLIENTS",
13-
],
10+
visibility = ["PUBLIC"],
1411
deps = [
1512
"//executorch/export:recipe_registry",
1613
":xnnpack_recipe_provider",
@@ -23,10 +20,7 @@ runtime.python_library(
2320
srcs = [
2421
"xnnpack_recipe_provider.py",
2522
],
26-
visibility = [
27-
"//executorch/...",
28-
"@EXECUTORCH_CLIENTS",
29-
],
23+
visibility = ["PUBLIC"],
3024
deps = [
3125
"//caffe2:torch",
3226
"//executorch/export:lib",
@@ -42,10 +36,7 @@ runtime.python_library(
4236
srcs = [
4337
"xnnpack_recipe_types.py",
4438
],
45-
visibility = [
46-
"//executorch/...",
47-
"@EXECUTORCH_CLIENTS",
48-
],
39+
visibility = ["PUBLIC"],
4940
deps = [
5041
"//executorch/export:recipe",
5142
],

0 commit comments

Comments
 (0)