Update on "Reuse GELU implementation from PyTorch core"

swolchok · swolchok · commit b3a0601f3f1b · 2024-11-22T16:27:59.000-08:00
kernels/optimized doesn't need to support embedded systems, so it can just take a header-only dep on PyTorch. Note that, because we will pick up Sleef internally and ignore it externally thanks to ATen vec, this PR gets to enable optimized GELU in OSS. Testing: CI to make sure this doesn't break mobile build modes; happy to take advice on anything not currently covered that might break. Differential Revision: [D66335522](https://our.internmc.facebook.com/intern/diff/D66335522/) [ghstack-poisoned]
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -337,7 +337,9 @@ if(NOT "${_repo_dir_name}" STREQUAL "executorch")
       "fix for this restriction."
   )
 endif()
-set(_common_include_directories ${CMAKE_CURRENT_SOURCE_DIR}/..)
+set(_common_include_directories ${CMAKE_CURRENT_SOURCE_DIR}/.. ${CMAKE_CURRENT_SOURCE_DIR}/runtime/core/portable_type)
+# We don't need any of C10's CMake macros.
+add_definitions(-DC10_USING_CUSTOM_GENERATED_MACROS)
 
 #
 # The `_<target>_srcs` lists are defined by including ${EXECUTORCH_SRCS_FILE}.

Original file line number	Diff line number	Diff line change
`@@ -337,7 +337,9 @@ if(NOT "${_repo_dir_name}" STREQUAL "executorch")`
`337`	`337`	`"fix for this restriction."`
`338`	`338`	`)`
`339`	`339`	`endif()`
`340`		`-set(_common_include_directories ${CMAKE_CURRENT_SOURCE_DIR}/..)`
	`340`	`+set(_common_include_directories ${CMAKE_CURRENT_SOURCE_DIR}/.. ${CMAKE_CURRENT_SOURCE_DIR}/runtime/core/portable_type)`
	`341`	`+# We don't need any of C10's CMake macros.`
	`342`	`+add_definitions(-DC10_USING_CUSTOM_GENERATED_MACROS)`
`341`	`343`
`342`	`344`	`#`
`343`	`345`	# The `_<target>_srcs` lists are defined by including ${EXECUTORCH_SRCS_FILE}.