Skip to content

Commit b832fe4

Browse files
committed
Revert the rpath to verify regression test works
1 parent 4230024 commit b832fe4

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

CMakeLists.txt

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -654,19 +654,19 @@ if(EXECUTORCH_BUILD_PYBIND)
654654
target_compile_options(portable_lib PUBLIC ${_pybind_compile_options})
655655
target_link_libraries(portable_lib PRIVATE ${_dep_libs})
656656

657-
# Set RPATH to find PyTorch libraries relative to the installation location
658-
# This goes from executorch/extension/pybindings up to site-packages, then to torch/lib
659-
if(APPLE)
660-
set_target_properties(portable_lib PROPERTIES
661-
BUILD_RPATH "@loader_path/../../../torch/lib"
662-
INSTALL_RPATH "@loader_path/../../../torch/lib"
663-
)
664-
else()
665-
set_target_properties(portable_lib PROPERTIES
666-
BUILD_RPATH "$ORIGIN/../../../torch/lib"
667-
INSTALL_RPATH "$ORIGIN/../../../torch/lib"
668-
)
669-
endif()
657+
# # Set RPATH to find PyTorch libraries relative to the installation location
658+
# # This goes from executorch/extension/pybindings up to site-packages, then to torch/lib
659+
# if(APPLE)
660+
# set_target_properties(portable_lib PROPERTIES
661+
# BUILD_RPATH "@loader_path/../../../torch/lib"
662+
# INSTALL_RPATH "@loader_path/../../../torch/lib"
663+
# )
664+
# else()
665+
# set_target_properties(portable_lib PROPERTIES
666+
# BUILD_RPATH "$ORIGIN/../../../torch/lib"
667+
# INSTALL_RPATH "$ORIGIN/../../../torch/lib"
668+
# )
669+
# endif()
670670

671671
install(TARGETS portable_lib
672672
LIBRARY DESTINATION executorch/extension/pybindings

0 commit comments

Comments
 (0)