Skip to content

Commit ba31994

Browse files
committed
Update on "[executorch][flat_tensor] implement load into and dont hold onto the segment"
1. Implement load_into in FlatTensorDataMap 2. Do not persist 'data_ro' in the FlatTensorDataMap. From `get_data`, return the FreeableBuffer given by the data loader. TODO: add test for load_into. Differential Revision: [D69148652](https://our.internmc.facebook.com/intern/diff/D69148652/) [ghstack-poisoned]
2 parents 33b9fd5 + ce8ad63 commit ba31994

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

extension/flat_tensor/flat_tensor_data_map.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ Result<const flat_tensor_flatbuffer::TensorMetadata*> get_flat_tensor_metadata(
5656
ET_CHECK_OR_RETURN_ERROR(
5757
metadata->segment_index() >= 0 && metadata->offset() >= 0,
5858
InvalidExternalData,
59-
"Invalid segment_index %d or offset %lu; malformed PTD file.",
59+
"Invalid segment_index %d or offset %" PRIu64 "; malformed PTD file.",
6060
metadata->segment_index(),
6161
metadata->offset());
6262
return metadata;
@@ -130,7 +130,8 @@ ET_NODISCARD Result<FreeableBuffer> FlatTensorDataMap::get_data(
130130
segment_offset.get() <
131131
header_.segment_base_offset + header_.segment_data_size,
132132
InvalidExternalData,
133-
"Invalid segment offset %d is larger than the segment_base_offset + segment_data_size %lu; malformed PTD file.",
133+
"Invalid segment offset %d is larger than the segment_base_offset + segment_data_size %" PRIu64
134+
"; malformed PTD file.",
134135
segment_offset.get(),
135136
header_.segment_base_offset + header_.segment_data_size);
136137
return loader_->load(

0 commit comments

Comments
 (0)