Update on "[Executorch] enable sleef consistently"

Earlier only android platofrms had support for sleef

Differential Revision: [D64571782](https://our.internmc.facebook.com/intern/diff/D64571782/)

[ghstack-poisoned]

Author: kimishpatel

extension/llm/custom_ops/targets.bzl

@@ -4,6 +4,10 @@ load(
     "get_vec_preprocessor_flags",
     "get_vec_deps",
 )
+load(
+    "@fbsource//xplat/executorch/kernels/portable:op_registration_util.bzl",
+    "get_compiler_optimization_flags",
+)
 
 def define_common_targets():
     """Defines targets that should be shared between fbcode and xplat.
@@ -40,21 +44,7 @@ def define_common_targets():
                 "//executorch/kernels/portable/cpu/util:reduce_util",
                 "//executorch/extension/llm/custom_ops/spinquant:fast_hadamard_transform",
             ] + get_vec_deps(),
-            compiler_flags = ["-Wno-missing-prototypes", "-Wno-global-constructors"] + select({
-              "DEFAULT": [],
-              "ovr_config//os:android-arm64": [
-                    "-O2",
-              ] if not runtime.is_oss else [],
-              "ovr_config//os:iphoneos": [
-                  "-O2",
-              ] if not runtime.is_oss else [],
-              "ovr_config//os:macos-arm64": [
-                  "-O2",
-              ] if not runtime.is_oss else [],
-              "ovr_config//os:macos-x86_64": [
-                  "-O2",
-              ] if not runtime.is_oss else [],
-            }),
+            compiler_flags = ["-Wno-missing-prototypes", "-Wno-global-constructors"] + get_compiler_optimization_flags(),
             visibility = [
                 "//executorch/...",
                 "//executorch/extension/llm/custom_ops/...",

kernels/optimized/lib_defs.bzl

@@ -2,6 +2,10 @@ load("@fbsource//tools/build_defs:default_platform_defs.bzl", "DEVSERVER_PLATFOR
 load("@fbsource//tools/build_defs:fb_native_wrapper.bzl", "fb_native")
 load("@fbsource//xplat/executorch/backends/xnnpack/third-party:third_party_libs.bzl", "third_party_dep")
 load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
+load(
+    "@fbsource//xplat/executorch/kernels/portable:op_registration_util.bzl",
+    "get_compiler_optimization_flags",
+)
 
 # Because vec exists as a collection of header files, compile and preprocessor
 # flags applied to the vec target do not have any effect, since no compilation
@@ -118,21 +122,7 @@ def define_libs():
             exported_headers = native.glob([
                 "blas/**/*.h",
             ]),
-            compiler_flags = select({
-              "DEFAULT": [],
-              "ovr_config//os:android-arm64": [
-                    "-O2",
-              ] if not runtime.is_oss else [],
-              "ovr_config//os:iphoneos": [
-                  "-O2",
-              ] if not runtime.is_oss else [],
-              "ovr_config//os:macos-arm64": [
-                  "-O2",
-              ] if not runtime.is_oss else [],
-              "ovr_config//os:macos-x86_64": [
-                  "-O2",
-              ] if not runtime.is_oss else [],
-            }),
+            compiler_flags = get_compiler_optimization_flags(),
             header_namespace = "executorch/kernels/optimized",
             visibility = [
                 "//executorch/...",

kernels/optimized/op_registration_util.bzl

@@ -4,6 +4,10 @@ load(
     "@fbsource//xplat/executorch/kernels/optimized:lib_defs.bzl",
     "get_vec_preprocessor_flags",
 )
+load(
+    "@fbsource//xplat/executorch/kernels/portable:op_registration_util.bzl",
+    "get_compiler_optimization_flags",
+)
 
 def op_target(name, deps = []):
     """Registers an optimized implementation for an operator overload group.
@@ -87,21 +91,7 @@ def define_op_library(name, deps):
         ],
         # kernels often have helpers with no prototypes just disabling the warning here as the headers
         # are codegend and linked in later
-        compiler_flags = ["-Wno-missing-prototypes"] + select({
-          "DEFAULT": [],
-          "ovr_config//os:android": [
-                "-O2",
-          ] if not runtime.is_oss else [],
-          "ovr_config//os:iphoneos": [
-              "-O2",
-          ] if not runtime.is_oss else [],
-          "ovr_config//os:macos-arm64": [
-              "-O2",
-          ] if not runtime.is_oss else [],
-          "ovr_config//os:macos-x86_64": [
-              "-O2",
-          ] if not runtime.is_oss else [],
-        }),
+        compiler_flags = ["-Wno-missing-prototypes"] + get_compiler_optimization_flags(),
         deps = [
             "//executorch/runtime/kernel:kernel_includes",
         ] + augmented_deps,

shim/xplat/executorch/kernels/portable/op_registration_util.bzl

@@ -1,6 +1,24 @@
 load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "is_xplat", "runtime")
 load("@fbsource//xplat/executorch/build:selects.bzl", "selects")
 
+def get_compiler_optimization_flags():
+    # various ovr_configs are not available in oss
+    if not runtime.is_oss:
+      compiler_flags = select({
+        "DEFAULT": [],
+        "ovr_config//os:android-arm64": [
+              "-O2",
+        ],
+        "ovr_config//os:iphoneos": [
+            "-O2",
+        ],
+        "ovr_config//os:macos-arm64": [
+            "-O2",
+        ],
+      })
+      return compiler_flags
+    return []
+
 def op_target(name, deps = [], android_deps = [], _allow_third_party_deps = False, _aten_mode_deps = []):
     """Registers an implementation of an operator overload group.
 
@@ -132,21 +150,7 @@ def define_op_library(name, deps, android_deps, aten_target, _allow_third_party_
             # library, and it blocks users like unit tests to use kernel
             # implementation directly. So we enable this for xplat only.
             ["-fvisibility=hidden"] if is_xplat() else []
-        ) + select({
-            "DEFAULT": [],
-            "ovr_config//os:android-arm64": [
-                  "-O2",
-            ] if not runtime.is_oss else [],
-            "ovr_config//os:iphoneos": [
-                "-O2",
-            ] if not runtime.is_oss else [],
-            "ovr_config//os:macos-arm64": [
-                "-O2",
-            ] if not runtime.is_oss else [],
-            "ovr_config//os:macos-x86_64": [
-                "-O2",
-            ] if not runtime.is_oss else [],
-          }),
+        ) + get_compiler_optimization_flags(),
         deps = [
             "//executorch/runtime/kernel:kernel_includes" + aten_suffix,
         ] + deps,