Add error messages to kernel checks

Author: Conarnar

kernels/prim_ops/register_prim_ops.cpp

@@ -22,9 +22,16 @@ namespace function {
 
 namespace {
 
-#define __ET_PRIM_OP_ERROR_IMPL(a, b, context)                \
-  else {                                                      \
-    ET_KERNEL_CHECK(context, false, InvalidType, /* void */); \
+#define __ET_PRIM_OP_ERROR_IMPL(a, b, context) \
+  else {                                       \
+    ET_KERNEL_CHECK_MSG(                       \
+        context,                               \
+        false,                                 \
+        InvalidType,                           \
+        /* void */,                            \
+        "%zu, %zu",                            \
+        (size_t)a.tag,                         \
+        (size_t)b.tag);                        \
   }
 
 #define __NUMBER_ET_PRIM_OP_IMPL(operator, stack, context) \
@@ -167,7 +174,14 @@ static Kernel prim_ops[] = {
           } else if (a.isDouble() && b.isInt()) {
             floor_div_double(a.toDouble(), static_cast<double>(b.toInt()), out);
           } else {
-            ET_KERNEL_CHECK(context, false, InvalidType, /* void */);
+            ET_KERNEL_CHECK_MSG(
+                context,
+                false,
+                InvalidType,
+                /* void */,
+                "%zu, %zu",
+                (size_t)a.tag,
+                (size_t)b.tag);
           }
         }),
 
@@ -191,7 +205,14 @@ static Kernel prim_ops[] = {
           } else if (a.isDouble() && b.isInt()) {
             out = EValue(a.toDouble() / b.toInt());
           } else {
-            ET_KERNEL_CHECK(context, false, InvalidType, /* void */);
+            ET_KERNEL_CHECK_MSG(
+                context,
+                false,
+                InvalidType,
+                /* void */,
+                "%zu, %zu",
+                (size_t)a.tag,
+                (size_t)b.tag);
           }
         }),
 
@@ -211,7 +232,8 @@ static Kernel prim_ops[] = {
             // TODO: This should be impossible
             out = EValue(a.toDouble());
           } else {
-            ET_KERNEL_CHECK(context, false, InvalidType, /* void */);
+            ET_KERNEL_CHECK_MSG(
+                context, false, InvalidType, /* void */, "%zu", (size_t)a.tag);
           }
         }),
 
@@ -261,7 +283,8 @@ static Kernel prim_ops[] = {
           } else if (a.isDouble()) {
             out = EValue(-a.toDouble());
           } else {
-            ET_KERNEL_CHECK(context, false, InvalidType, /* void */);
+            ET_KERNEL_CHECK_MSG(
+                context, false, InvalidType, /* void */, "%zu", (size_t)a.tag);
           }
         }),
 
@@ -298,7 +321,14 @@ static Kernel prim_ops[] = {
           if (a.isInt() && b.isInt()) {
             out = EValue(a.toInt() % b.toInt());
           } else {
-            ET_KERNEL_CHECK(context, false, InvalidType, /* void */);
+            ET_KERNEL_CHECK_MSG(
+                context,
+                false,
+                InvalidType,
+                /* void */,
+                "%zu, %zu",
+                (size_t)a.tag,
+                (size_t)b.tag);
           }
         }),
 
@@ -312,7 +342,13 @@ static Kernel prim_ops[] = {
           if (a.isDouble()) {
             out = EValue(static_cast<int64_t>(ceil(a.toDouble())));
           } else {
-            ET_KERNEL_CHECK(context, false, InvalidType, /* void */);
+            ET_KERNEL_CHECK_MSG(
+                context,
+                false,
+                InvalidType,
+                /* void */,
+                "Unsupported DType %zu",
+                (size_t)a.tag);
           }
         }),
 
@@ -343,7 +379,13 @@ static Kernel prim_ops[] = {
 
             out = EValue(static_cast<int64_t>(res));
           } else {
-            ET_KERNEL_CHECK(context, false, InvalidType, /* void */);
+            ET_KERNEL_CHECK_MSG(
+                context,
+                false,
+                InvalidType,
+                /* void */,
+                "Unsupported DType %zu",
+                (size_t)a.tag);
           }
         }),
 
@@ -357,7 +399,8 @@ static Kernel prim_ops[] = {
           if (a.isDouble()) {
             out = EValue(static_cast<int64_t>(trunc(a.toDouble())));
           } else {
-            ET_KERNEL_CHECK(context, false, InvalidType, /* void */);
+            ET_KERNEL_CHECK_MSG(
+                context, false, InvalidType, /* void */, "%zu", (size_t)a.tag);
           }
         }),