Think I fixed the ci runner, but having issues with building the size test

Author: Github Executorch

.github/workflows/trunk.yml

@@ -293,14 +293,13 @@ jobs:
         .ci/scripts/setup-arm-zephyr-tools.sh
         source examples/arm/ethos-u-scratch/setup_path.sh
 
-        # User baremetal toolchain
+        # Use arm zephyr toolchain
         arm-zephyr-eabi-c++ --version
-        toolchain_cmake=examples/arm/ethos-u-setup/arm-zephyr-eabi-gcc.cmake
-        toolchain_cmake=$(realpath ${toolchain_cmake})
+        zephyr_preset=tools/cmake/preset/zephyr.cmake
+        zephyr_preset=$(realpath ${zephyr_preset})
 
         # Build and test size test
-        cmake --preset zephyr
-        bash test/build_size_test.sh "-DCMAKE_TOOLCHAIN_FILE=${toolchain_cmake}"
+        bash test/build_size_test.sh "-DEXECUTORCH_BUILD_PRESET_FILE=${zephyr_preset}"
         elf="cmake-out/test/size_test"
 
         # Dump basic info
@@ -317,7 +316,7 @@ jobs:
         output=$(ls -la ${elf})
         arr=($output)
         size=${arr[4]}
-        threshold="103268" # ~100KiB
+        threshold="153600" # should be ~138KB, set threashold to 150KB
         echo "size: $size, threshold: $threshold"
         if [[ "$size" -le "$threshold" ]]; then
           echo "Success $size <= $threshold"

examples/arm/ethos-u-setup/arm-zephyr-eabi-gcc.cmake

@@ -101,6 +101,9 @@ add_compile_options(
   # -Wall -Wextra -Wcast-align -Wdouble-promotion -Wformat
   # -Wmissing-field-initializers -Wnull-dereference -Wredundant-decls -Wshadow
   # -Wswitch -Wswitch-default -Wunused -Wno-redundant-decls
+  -Wno-stringop-overread
+  -Wno-error=format=
+  -Wno-error=maybe-uninitialized
   -Wno-error=deprecated-declarations
   -Wno-error=shift-count-overflow
   -Wno-psabi

runtime/executor/pte_data_map.cpp

@@ -32,7 +32,7 @@ PteDataMap::get_data(executorch::aten::string_view key) const {
     ET_CHECK_OR_RETURN_ERROR(
         named_data_->Get(i) != nullptr && named_data_->Get(i)->key() != nullptr,
         InvalidArgument,
-        "Searching for key %.*s: NamedData at index %d is null",
+        "Searching for key %.*s: NamedData at index %" PRId32 " is null",
         static_cast<int>(key.size()),
         key.data(),
         i);
@@ -47,7 +47,7 @@ PteDataMap::get_data(executorch::aten::string_view key) const {
       ET_CHECK_OR_RETURN_ERROR(
           segment_index < segments_->size(),
           InvalidArgument,
-          "Segment index %zu for key %.*s is out of range for segments size %u",
+          "Segment index %zu for key %.*s is out of range for segments size %" PRId32,
           segment_index,
           static_cast<int>(key.size()),
           key.data(),
@@ -74,15 +74,15 @@ ET_NODISCARD executorch::runtime::Result<const char*> PteDataMap::get_key(
   ET_CHECK_OR_RETURN_ERROR(
       index < named_data_->size(),
       InvalidArgument,
-      "Index out of range: named_data size is %u, received index %u",
+      "Index out of range: named_data size is %" PRId32 ", received index %" PRId32,
       named_data_->size(),
       index);
 
   ET_CHECK_OR_RETURN_ERROR(
       named_data_->Get(index) != nullptr &&
           named_data_->Get(index)->key() != nullptr,
       InvalidArgument,
-      "NamedData at index %u is null",
+      "NamedData at index %" PRId32 " is null",
       index);
   return named_data_->Get(index)->key()->c_str();
 }

runtime/executor/tensor_parser_exec_aten.cpp

@@ -133,7 +133,7 @@ ET_NODISCARD Error validateTensorLayout(
     ET_CHECK_OR_RETURN_ERROR(
         s_tensor->sizes()->Get(i) == expected_layout.sizes()[i],
         InvalidExternalData,
-        "Sizes mismatch. Expected %d, got %d for size at index %d.",
+        "Sizes mismatch. Expected %" PRId32 ", got %" PRId32 " for size at index %d.",
         s_tensor->sizes()->Get(i),
         expected_layout.sizes()[i],
         i);

runtime/kernel/operator_registry.h

@@ -34,7 +34,7 @@
   for (const auto& meta : meta_list) {                               \
     ET_LOG(Info, "dtype: %d | dim order: [", int(meta.dtype_));      \
     for (size_t i = 0; i < meta.dim_order_.size(); i++) {            \
-      ET_LOG(Info, "%d,", static_cast<int32_t>(meta.dim_order_[i])); \
+      ET_LOG(Info, "%" PRId32 ",", static_cast<int32_t>(meta.dim_order_[i])); \
     }                                                                \
     ET_LOG(Info, "]");                                               \
   }