Skip to content

Commit c187a57

Browse files
committed
Dave comments
1 parent 0c8812f commit c187a57

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

.github/pull_request_template.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
[PLEASE REMOVE] If this PR closes an issue, please add a `Fixes #<issue-id>` line.
55

6-
[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add the following "Release notes: <area>" label.
6+
[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: <area>" label.
77

88
### Test plan
99
[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written.

CONTRIBUTING.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -242,14 +242,19 @@ for basics.
242242
- Give the PR a clear and thorough description. Don't just describe what the PR
243243
does: the diff will do that. Explain *why* you are making this change, in a
244244
way that will make sense to someone years from now.
245-
- Add the line `Test Plan:` (with that spelling, capitalization, and trailing
246-
colon character), followed by lines containing repeatable instructions for
245+
- Explain how you have tested your changes by including repeatable instructions for
247246
testing the PR.
248247
- If you added tests, this can be as simple as the command you used to run the
249248
tests.
250249
- If you tested the PR manually, include the steps and the outputs. Help a
251250
future editor understand how to test the code that you're modifying
252251
today.
252+
- If your PR contains or is representative of a feature/bug fix that should be
253+
called out in the release notes, please add a label for "Release notes: <area>",
254+
where <area> describes which part of ExecuTorch the change pertains to, e.g.
255+
"Release notes: runtime". A few of these areas include "runtime", "backends",
256+
and "build". If you aren't sure whether to add a release label, you should
257+
probably still add one since it immensely facilitates release management.
253258
- See https://github.com/pytorch/executorch/pull/3612 for an example PR that
254259
follows this advice.
255260
1. Before asking for a review, ensure that all [CI (continuous integration)

0 commit comments

Comments
 (0)