Skip to content

Commit c36cd92

Browse files
hsharma35facebook-github-bot
authored andcommitted
Cleanup executorch::aten::... for cadence operators.
Summary: 1. Remove all using-declarations and `namespace at/c10 = ...` from headers. 2. Use `::executorch::aten::...` instead of `at::...` or `c10::...` in cpp files. Reviewed By: dbort Differential Revision: D64864409
1 parent cb25809 commit c36cd92

File tree

3 files changed

+15
-14
lines changed

3 files changed

+15
-14
lines changed

backends/cadence/hifi/operators/op_add.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,18 @@
1414
#include <executorch/runtime/kernel/kernel_includes.h>
1515
#include <executorch/runtime/platform/assert.h>
1616

17-
using exec_aten::Scalar;
18-
using exec_aten::ScalarType;
19-
using exec_aten::Tensor;
20-
using executorch::runtime::can_cast;
21-
using executorch::runtime::CppTypeToScalarType;
22-
using executorch::runtime::KernelRuntimeContext;
23-
using torch::executor::Error;
24-
2517
namespace impl {
2618
namespace HiFi {
2719
namespace native {
2820

21+
using ::executorch::aten::Scalar;
22+
using ::executorch::aten::ScalarType;
23+
using ::executorch::aten::Tensor;
24+
using ::executorch::runtime::can_cast;
25+
using ::executorch::runtime::CppTypeToScalarType;
26+
using ::executorch::runtime::Error;
27+
using ::executorch::runtime::KernelRuntimeContext;
28+
2929
namespace {
3030
template <
3131
bool can_cast,

backends/cadence/hifi/operators/op_tanh.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111
#include <executorch/runtime/kernel/kernel_includes.h>
1212
#include <cmath>
1313

14-
using exec_aten::ScalarType;
15-
using exec_aten::Tensor;
16-
using executorch::aten::RuntimeContext;
17-
using torch::executor::Error;
14+
using ::executorch::aten::RuntimeContext;
15+
using ::executorch::aten::ScalarType;
16+
using ::executorch::aten::Tensor;
17+
using ::executorch::runtime::Error;
1818

1919
namespace cadence {
2020
namespace impl {
@@ -41,4 +41,4 @@ Tensor& tanh_out(RuntimeContext& ctx, const Tensor& in, Tensor& out) {
4141
} // namespace native
4242
} // namespace HiFi
4343
} // namespace impl
44-
} // namespace cadence
44+
} // namespace cadence

backends/cadence/hifi/operators/targets.bzl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ def define_common_targets():
1717
]),
1818
platforms = CXX,
1919
deps = [
20-
"//executorch/kernels/portable/cpu/util:broadcast_util",
20+
"//executorch/kernels/portable/cpu/util:all_deps",
21+
"//executorch/kernels/portable/cpu/pattern:all_deps",
2122
"//executorch/runtime/kernel:kernel_includes",
2223
"//executorch/kernels/portable/cpu:scalar_utils",
2324
"fbsource//third-party/nnlib-hifi4/xa_nnlib:libxa_nnlib",

0 commit comments

Comments
 (0)