Skip to content

Commit c643605

Browse files
committed
Fix installation that causes torch conflict
A package in requirements-examples.txt had a dependency on torchvision, and we ended up installing stable release from standard pypi package. And transitively we ended up installing stable torch and uninstalling torch library.
1 parent 48e4822 commit c643605

File tree

2 files changed

+13
-14
lines changed

2 files changed

+13
-14
lines changed

install_executorch.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ def clean():
6565
print("ccache not found, skipping ccache cleanup.")
6666
except (subprocess.CalledProcessError, FileNotFoundError):
6767
print("ccache not found, skipping ccache cleanup.")
68-
6968
print("Done cleaning build artifacts.")
7069

7170

install_requirements.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -142,19 +142,6 @@ def install_requirements(use_pytorch_nightly):
142142

143143

144144
def install_optional_example_requirements(use_pytorch_nightly):
145-
print("Installing packages in requirements-examples.txt")
146-
subprocess.run(
147-
[
148-
sys.executable,
149-
"-m",
150-
"pip",
151-
"install",
152-
"-r",
153-
"requirements-examples.txt",
154-
],
155-
check=True,
156-
)
157-
158145
print("Installing torch domain libraries")
159146
DOMAIN_LIBRARIES = [
160147
(
@@ -178,6 +165,19 @@ def install_optional_example_requirements(use_pytorch_nightly):
178165
check=True,
179166
)
180167

168+
print("Installing packages in requirements-examples.txt")
169+
subprocess.run(
170+
[
171+
sys.executable,
172+
"-m",
173+
"pip",
174+
"install",
175+
"-r",
176+
"requirements-examples.txt",
177+
],
178+
check=True,
179+
)
180+
181181

182182
# Prebuilt binaries for Intel-based macOS are no longer available on PyPI; users must compile from source.
183183
# PyTorch stopped building macOS x86_64 binaries since version 2.3.0 (January 2024).

0 commit comments

Comments
 (0)