Skip to content

Commit c849300

Browse files
committed
Update base for Update on "[ET-VK] Removing unnecessary and redundant members from StagingBuffer."
This diff removes unnecessary and redundant members from the StagingBuffer class in the Vulkan runtime API. Specifically, the `numel_` and `nbytes_` members are removed, as they can be calculated from the `dtype_` member. This simplifies the class and reduces the amount of memory used. Differential Revision: [D66742613](https://our.internmc.facebook.com/intern/diff/D66742613/) [ghstack-poisoned]
1 parent 6f552c7 commit c849300

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

backends/vulkan/test/vulkan_compute_api_test.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1087,8 +1087,8 @@ TEST_F(VulkanComputeAPITest, print_object_sizes) {
10871087

10881088
// Current known size on 64 bit system: 1040 B
10891089
EXPECT_TRUE(sizeof(vTensor) < 1200);
1090-
// Current known size on 64 bit system: 32 B
1091-
EXPECT_TRUE(sizeof(Value) < 40);
1090+
// Current known size on 64 bit system: 48 B
1091+
EXPECT_TRUE(sizeof(Value) < 56);
10921092
// Current known size on 64 bit system: 120 B
10931093
EXPECT_TRUE(sizeof(StagingBuffer) < 500);
10941094
// Current known size on 64 bit system: 384 B

0 commit comments

Comments
 (0)