Skip to content

Commit cb04035

Browse files
authored
Updated the shared_ptr_data_loader.h
I have merge the declaration and implementation of 'load_into' function.
1 parent fea2310 commit cb04035

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

extension/data_loader/shared_ptr_data_loader.h

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -49,17 +49,7 @@ class SharedPtrDataLoader final : public executorch::runtime::DataLoader {
4949
size_t offset,
5050
size_t size,
5151
const DataLoader::SegmentInfo& segment_info,
52-
void* buffer) const override;
53-
54-
ET_NODISCARD executorch::runtime::Result<size_t> size() const override {
55-
return size_;
56-
}
57-
58-
ET_NODISCARD executorch::runtime::Error SharedPtrDataLoader::load_into(
59-
size_t offset,
60-
size_t size,
61-
const DataLoader::SegmentInfo& segment_info,
62-
void* buffer) const {
52+
void* buffer) const override {
6353
ET_CHECK_OR_RETURN_ERROR(
6454
offset + size <= size_,
6555
executorch::runtime::Error::OutOfBounds,
@@ -70,8 +60,11 @@ class SharedPtrDataLoader final : public executorch::runtime::DataLoader {
7060

7161
std::memcpy(buffer, static_cast<uint8_t*>(data_.get()) + offset, size);
7262
return executorch::runtime::Error::Ok;
73-
}
63+
}
7464

65+
ET_NODISCARD executorch::runtime::Result<size_t> size() const override {
66+
return size_;
67+
}
7568

7669
private:
7770
const std::shared_ptr<void> data_;

0 commit comments

Comments
 (0)