Skip to content

Commit cc7d899

Browse files
committed
Fix upsteam review comments
Signed-off-by: Adrian Lundell <[email protected]>
1 parent 9a4440e commit cc7d899

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

backends/arm/_passes/to_tosa_memory_format_pass.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -253,22 +253,22 @@ def insert_tosa_transposes(self, graph_module: torch.fx.GraphModule):
253253
for input_node in inputs:
254254
input_dim_order = get_first_fake_tensor(input_node).dim_order()
255255
if input_dim_order in (NCHW_ORDER, NNCHW_ORDER):
256-
ToTosaMemoryFormatPass.insert_output_transpose(input_node, graph_module)
256+
self.insert_output_transpose(input_node, graph_module)
257257

258258
# Transpose outputs if they are in (N)NCHW format
259259
outputs = output_node.args[0]
260260
output_dim_orders = output_node.meta.get("original_dim_orders")
261261
if output_dim_orders is None:
262262
raise RuntimeError(
263-
f"{AnnotateDecomposedMatmulPass.__name__} is required to run at the beginning of the pass pipeline when using {ToTosaMemoryFormatPass.__name__}."
263+
f"{AnnotateDecomposedMatmulPass.__name__} is required to run at the beginning of the pass pipeline when using {self.__name__}."
264264
)
265265

266266
for output_node_input, output_dim_order in zip(outputs, output_dim_orders): # type: ignore[arg-type]
267267
if output_dim_order in (
268268
NCHW_ORDER,
269269
NNCHW_ORDER,
270270
):
271-
ToTosaMemoryFormatPass.insert_input_transpose(
271+
self.insert_input_transpose(
272272
output_node, output_node_input, graph_module
273273
)
274274

backends/arm/test/targets.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def define_arm_tests():
3939
"misc/test_bn_relu_folding_qat.py",
4040
"misc/test_custom_partition.py",
4141
"misc/test_debug_hook.py",
42-
"misc/test_dim_order_guards.py",
42+
"misc/test_dim_order.py",
4343
"misc/test_outputs_order.py",
4444
]
4545

0 commit comments

Comments
 (0)