Skip to content

Commit cd30edf

Browse files
bigfootjonfacebook-github-bot
authored andcommitted
Remove tombstone messages proactively (#8703)
Summary: X-link: pytorch/pytorch#147897 Originally we created a bunch of empty `TARGETS` files to allow us to enable `BUCK` files in fbcode by hiding the existing BUCK file. These files were subsequently merged together using `non_fbcode_target` so these tombstones are no longer necessary. This diff fixes all files that WOULD have had the useless tombstone merged into them. To create this diff, I just ran the merger script that Codemod Service is using and then deleted the "merged from" and tombstone lines with `sed`, `arc f` and reverted any lines that didn't make sense Differential Revision: D69994481
1 parent afcec1d commit cd30edf

File tree

11 files changed

+19
-22
lines changed

11 files changed

+19
-22
lines changed

examples/demo-apps/android/ExecuTorchDemo/app/src/main/BUCK

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
1+
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
12
load("@fbsource//tools/build_defs:manifold.bzl", "manifold_get")
23
load("@fbsource//tools/build_defs/android:fb_android_binary.bzl", "fb_android_binary")
34
load("@fbsource//tools/build_defs/android:fb_android_library.bzl", "fb_android_library")
45
load("@fbsource//tools/build_defs/android:fb_android_resource.bzl", "fb_android_resource")
56

6-
manifold_get(
7+
non_fbcode_target(_kind = manifold_get,
78
name = "dl3_xnnpack_fp32",
89
out = "dl3_xnnpack_fp32.pte",
910
api_key = "executorch-key",
@@ -13,21 +14,21 @@ manifold_get(
1314
timeout_msec = 120000,
1415
)
1516

16-
fb_android_resource(
17+
non_fbcode_target(_kind = fb_android_resource,
1718
name = "app_res",
1819
assets = "assets",
1920
package = "com.example.executorchdemo",
2021
res = "res",
2122
)
2223

23-
fb_android_resource(
24+
non_fbcode_target(_kind = fb_android_resource,
2425
name = "model_res",
2526
assets = {"dl3_xnnpack_fp32.pte": ":dl3_xnnpack_fp32"},
2627
package = "com.example.executorchdemo",
2728
res = "res",
2829
)
2930

30-
fb_android_library(
31+
non_fbcode_target(_kind = fb_android_library,
3132
name = "app_lib",
3233
srcs = [
3334
"java/com/example/executorchdemo/ClassificationActivity.java",
@@ -43,7 +44,7 @@ fb_android_library(
4344
],
4445
)
4546

46-
fb_android_binary(
47+
non_fbcode_target(_kind = fb_android_binary,
4748
name = "ExecuTorchDemo",
4849
keystore = "//fbandroid/keystores:debug",
4950
manifest = "AndroidManifest.xml",

examples/demo-apps/android/ExecuTorchDemo/app/src/main/TARGETS

Lines changed: 0 additions & 1 deletion
This file was deleted.

examples/demo-apps/android/LlamaDemo/app/src/main/BUCK

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
1+
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
12
load("@fbsource//tools/build_defs/android:fb_android_binary.bzl", "fb_android_binary")
23
load("@fbsource//tools/build_defs/android:fb_android_library.bzl", "fb_android_library")
34
load("@fbsource//tools/build_defs/android:fb_android_resource.bzl", "fb_android_resource")
45

56
oncall("executorch")
67

7-
fb_android_resource(
8+
non_fbcode_target(_kind = fb_android_resource,
89
name = "app_res",
910
package = "com.example.executorchllamademo",
1011
res = "res",
1112
)
1213

13-
fb_android_library(
14+
non_fbcode_target(_kind = fb_android_library,
1415
name = "app_lib",
1516
srcs = [
1617
"java/com/example/executorchllamademo/AppLog.java",
@@ -43,7 +44,7 @@ fb_android_library(
4344
],
4445
)
4546

46-
fb_android_binary(
47+
non_fbcode_target(_kind = fb_android_binary,
4748
name = "ExecuTorchLlamaDemo",
4849
keystore = "//fbandroid/keystores:debug",
4950
manifest = "AndroidManifest.xml",

examples/demo-apps/android/LlamaDemo/app/src/main/TARGETS

Lines changed: 0 additions & 1 deletion
This file was deleted.

extension/android/BUCK

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1+
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
12
load("@fbsource//tools/build_defs/android:fb_android_library.bzl", "fb_android_library")
23

34
oncall("executorch")
45

5-
fb_android_library(
6+
non_fbcode_target(_kind = fb_android_library,
67
name = "executorch",
78
srcs = [
89
"src/main/java/org/pytorch/executorch/DType.java",
@@ -20,7 +21,7 @@ fb_android_library(
2021
],
2122
)
2223

23-
fb_android_library(
24+
non_fbcode_target(_kind = fb_android_library,
2425
name = "executorch_llama",
2526
srcs = [
2627
"src/main/java/org/pytorch/executorch/LlamaCallback.java",

extension/android/TARGETS

Lines changed: 0 additions & 1 deletion
This file was deleted.

extension/android/jni/BUCK

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
1+
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
12
load("@fbsource//tools/build_defs/android:fb_android_cxx_library.bzl", "fb_android_cxx_library")
23
load("@fbsource//xplat/executorch/backends/xnnpack/third-party:third_party_libs.bzl", "third_party_dep")
34
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
45
load("@fbsource//xplat/executorch/codegen:codegen.bzl", "executorch_generated_lib")
56

67
oncall("executorch")
78

8-
executorch_generated_lib(
9+
non_fbcode_target(_kind = executorch_generated_lib,
910
name = "generated_op_lib_optimized",
1011
custom_ops_aten_kernel_deps = [
1112
"//executorch/kernels/portable:operators_aten",
@@ -24,7 +25,7 @@ executorch_generated_lib(
2425
],
2526
)
2627

27-
fb_android_cxx_library(
28+
non_fbcode_target(_kind = fb_android_cxx_library,
2829
name = "executorch_jni",
2930
srcs = ["jni_layer.cpp", "log.cpp"],
3031
headers = ["jni_layer_constants.h"],
@@ -49,7 +50,7 @@ fb_android_cxx_library(
4950
],
5051
)
5152

52-
fb_android_cxx_library(
53+
non_fbcode_target(_kind = fb_android_cxx_library,
5354
name = "executorch_jni_full",
5455
srcs = ["jni_layer.cpp", "log.cpp"],
5556
headers = ["jni_layer_constants.h"],
@@ -74,7 +75,7 @@ fb_android_cxx_library(
7475
],
7576
)
7677

77-
fb_android_cxx_library(
78+
non_fbcode_target(_kind = fb_android_cxx_library,
7879
name = "executorch_llama_jni",
7980
srcs = [
8081
"jni_layer.cpp",
@@ -106,7 +107,7 @@ fb_android_cxx_library(
106107
],
107108
)
108109

109-
runtime.cxx_library(
110+
non_fbcode_target(_kind = runtime.cxx_library,
110111
name = "log_provider",
111112
srcs = ["log.cpp"],
112113
exported_headers = ["log.h"],

extension/android/jni/TARGETS

Lines changed: 0 additions & 1 deletion
This file was deleted.

extension/android_test/TARGETS

Lines changed: 0 additions & 1 deletion
This file was deleted.

extension/apple/ExecuTorch/TARGETS

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)