Skip to content

Commit d53774f

Browse files
committed
Update on "[ET-VK] Introduce generalized shaders for transfer ops and use it for select and slice"
## Changes * Introduce `transfer_buffer.glsl` and `transfer_texture.glsl`, and `Transfer.cpp` which generalizes shaders where each element of the output is copied from a unique element of the input. * Update `Slice.cpp` and `Select.cpp` to use `Transfer.cpp` * Remove old implementations of slice and select ## Motivation With this new implementation, the op can now support both buffers and textures of any packing. There are also benefits of code consolidation. Differential Revision: [D75686050](https://our.internmc.facebook.com/intern/diff/D75686050/) [ghstack-poisoned]
2 parents f7dc66c + ed2d377 commit d53774f

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

backends/vulkan/runtime/VulkanBackend.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,6 @@ class VulkanBackend final : public ::executorch::runtime::BackendInterface {
569569

570570
if (should_propagate_resize) {
571571
compute_graph->propagate_resize();
572-
compute_graph->encode_execute();
573572
}
574573
compute_graph->execute();
575574

backends/vulkan/runtime/graph/ComputeGraph.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -712,6 +712,7 @@ void ComputeGraph::propagate_resize() {
712712
for (std::unique_ptr<ExecuteNode>& node : execute_nodes_) {
713713
node->trigger_resize(this);
714714
}
715+
encode_execute();
715716
}
716717

717718
} // namespace vkcompute

0 commit comments

Comments
 (0)