Commit d59a511
Add a null check for `event_tracer` param in the `Module::load_method` (#6298)
Summary:
Pull Request resolved: #6298
When testing the [LLM Manual](https://pytorch.org/executorch/0.4/llm/getting-started.html#profiling-and-debugging), I found etdump is not generated :(. It seems to be a bug introduced in D62520386 when a `tracer` parameter was added to `Module::load_method`. It overrides the `event_tracer_.get()`, resulting `tracer` being null and passed to `program_->load_method`, thus etdump is not generated.
This diff just adds a check: it `tracer` is not null, use it; otherwise use the tracer get from class member event_tracer_.
Reviewed By: tarun292, Gasoonjia, dbort
Differential Revision: D64481537
fbshipit-source-id: 86cecbaea2b7293be28d60f4147deb31535fa6ea
(cherry picked from commit ad0e5e8)
Co-authored-by: Olivia Liu <[email protected]>
1 parent da2cd5b commit d59a511
2 files changed
+8
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
| 128 | + | |
129 | 129 | | |
130 | 130 | | |
131 | 131 | | |
| |||
153 | 153 | | |
154 | 154 | | |
155 | 155 | | |
156 | | - | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
157 | 159 | | |
158 | 160 | | |
159 | 161 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
137 | 140 | | |
138 | 141 | | |
139 | 142 | | |
| |||
0 commit comments