Update on "[ET-VK] Adding push constant and ubo verison of select and slice ops to improve memory and performance."

trivedivivek · trivedivivek · commit d746b7ba4d70 · 2025-07-10T17:44:42.000-07:00
Adding push constant and ubo verison of select and slice ops to improve memory and performance. * Updated `transfer_buffer.yaml` and `transfer_texture.yaml` to include `UBO_PARAMS` parameter and generate variants for `select` and `slice` ops with UBO parameters. * Updated `transfer.glsl` to generate ubo and push constant versions of `select` and `slice` ops with UBO parameters. Differential Revision: [D78095262](https://our.internmc.facebook.com/intern/diff/D78095262/) [ghstack-poisoned]
diff --git a/backends/vulkan/runtime/graph/ops/impl/Transfer.cpp b/backends/vulkan/runtime/graph/ops/impl/Transfer.cpp
@@ -81,11 +81,10 @@ void add_transfer_copy_node(
   }
 
   if (param_is_scalar) {
-    push_constants.emplace_back(
-        PushConstantDataInfo(&transfer_params, sizeof(transfer_params)));
+    push_constants.emplace_back(&transfer_params, sizeof(transfer_params));
   } else {
-    push_constants.emplace_back(PushConstantDataInfo(
-        &transfer_params.dim, sizeof(transfer_params.dim)));
+    push_constants.emplace_back(
+        &transfer_params.dim, sizeof(transfer_params.dim));
   }
 
   vkapi::SpecVarList spec_vars = {

Original file line number	Diff line number	Diff line change
`@@ -81,11 +81,10 @@ void add_transfer_copy_node(`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`if (param_is_scalar) {`
`84`		`- push_constants.emplace_back(`
`85`		`- PushConstantDataInfo(&transfer_params, sizeof(transfer_params)));`
	`84`	`+ push_constants.emplace_back(&transfer_params, sizeof(transfer_params));`
`86`	`85`	`} else {`
`87`		`- push_constants.emplace_back(PushConstantDataInfo(`
`88`		`- &transfer_params.dim, sizeof(transfer_params.dim)));`
	`86`	`+ push_constants.emplace_back(`
	`87`	`+ &transfer_params.dim, sizeof(transfer_params.dim));`
`89`	`88`	`}`
`90`	`89`
`91`	`90`	`vkapi::SpecVarList spec_vars = {`