Skip to content

Commit d75912b

Browse files
SS-JIAfacebook-github-bot
authored andcommitted
Use libtorch target in generated operator tests/benchmarks instead of custom op lib target
Summary: TSIA. Previously, a custom ATen operator library target was being used as a dependency in the generated operator tests to access ATen operator implementations. However, it seems that using the `libtorch` target works as well. Change everything to just use `libtorch` to 1. Simplify dependencies 2. The custom ATen operator library target does not build on Windows for some reason Differential Revision: D66964157
1 parent 4adbdce commit d75912b

File tree

1 file changed

+2
-20
lines changed

1 file changed

+2
-20
lines changed

backends/vulkan/test/op_tests/targets.bzl

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -82,24 +82,6 @@ def define_common_targets(is_fbcode = False):
8282
default_outs = ["."],
8383
)
8484

85-
pt_operator_library(
86-
name = "all_aten_ops",
87-
check_decl = False,
88-
include_all_operators = True,
89-
)
90-
91-
runtime.cxx_library(
92-
name = "all_aten_ops_lib",
93-
srcs = [],
94-
define_static_target = False,
95-
exported_deps = get_pt_ops_deps(
96-
name = "pt_ops_full",
97-
deps = [
98-
":all_aten_ops",
99-
],
100-
),
101-
)
102-
10385
runtime.cxx_binary(
10486
name = "compute_graph_op_tests_bin",
10587
srcs = [
@@ -109,7 +91,7 @@ def define_common_targets(is_fbcode = False):
10991
deps = [
11092
"//third-party/googletest:gtest_main",
11193
"//executorch/backends/vulkan:vulkan_graph_runtime",
112-
":all_aten_ops_lib",
94+
runtime.external_dep_location("libtorch"),
11395
],
11496
)
11597

@@ -125,7 +107,7 @@ def define_common_targets(is_fbcode = False):
125107
deps = [
126108
"//third-party/benchmark:benchmark",
127109
"//executorch/backends/vulkan:vulkan_graph_runtime",
128-
":all_aten_ops_lib",
110+
runtime.external_dep_location("libtorch"),
129111
],
130112
)
131113

0 commit comments

Comments
 (0)