Skip to content

Commit d7686d4

Browse files
committed
Make it work
1 parent ef6f203 commit d7686d4

File tree

9 files changed

+1216
-623
lines changed

9 files changed

+1216
-623
lines changed

extension/llm/runner/CMakeLists.txt

Lines changed: 13 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -82,43 +82,29 @@ endif()
8282

8383
# Python bindings for MultimodalRunner
8484
if(EXECUTORCH_BUILD_PYBIND)
85-
# Find pybind11
86-
find_package(pybind11 REQUIRED)
87-
8885
# Create the Python extension module for LLM runners
8986
pybind11_add_module(
90-
_llm_runner
91-
${CMAKE_CURRENT_SOURCE_DIR}/pybindings.cpp
87+
_llm_runner SHARED ${CMAKE_CURRENT_SOURCE_DIR}/pybindings.cpp
9288
)
93-
89+
9490
# Link with the extension_llm_runner library and its dependencies
9591
target_link_libraries(
96-
_llm_runner
97-
PRIVATE
98-
extension_llm_runner
99-
executorch_core
100-
extension_module
101-
extension_tensor
102-
tokenizers::tokenizers
92+
_llm_runner PRIVATE extension_llm_runner executorch_core extension_module
93+
extension_tensor tokenizers::tokenizers
10394
)
104-
95+
10596
# Set properties for the Python extension
10697
set_target_properties(
10798
_llm_runner
108-
PROPERTIES
109-
POSITION_INDEPENDENT_CODE ON
110-
CXX_VISIBILITY_PRESET "hidden"
111-
INTERPROCEDURAL_OPTIMIZATION TRUE
112-
PREFIX "${PYTHON_MODULE_PREFIX}"
113-
SUFFIX "${PYTHON_MODULE_SUFFIX}"
99+
PROPERTIES POSITION_INDEPENDENT_CODE ON
100+
CXX_VISIBILITY_PRESET "hidden"
101+
INTERPROCEDURAL_OPTIMIZATION TRUE
114102
)
115-
103+
116104
# Add include directories
117-
target_include_directories(
118-
_llm_runner
119-
PRIVATE
120-
${_common_include_directories}
121-
${CMAKE_CURRENT_SOURCE_DIR}
122-
${CMAKE_CURRENT_SOURCE_DIR}/../sampler
105+
target_include_directories(_llm_runner PRIVATE ${_common_include_directories})
106+
107+
install(TARGETS _llm_runner
108+
LIBRARY DESTINATION executorch/extension/llm/runner
123109
)
124110
endif()

0 commit comments

Comments
 (0)