Skip to content

Commit d9bbd32

Browse files
author
Github Executorch
committed
Adding correct flag to make sure build size test is accurate, updated threshold
1 parent 96ba4ae commit d9bbd32

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/trunk.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ jobs:
246246
elif [[ ${{ matrix.os}} == "zephyr-preset" ]]; then
247247
setup_script=.ci/scripts/setup-arm-zephyr-x86-64-tools.sh
248248
toolchain_prefix=arm-zephyr-eabi-
249-
threshold="225280" # should be ~216KB, set threshold to 220KB
249+
threshold="133120" # should be ~125KB, set threshold to 130KB
250250
else
251251
echo "Fail unsupport OS selection ${{ matrix.os }}"
252252
exit 1
@@ -269,7 +269,7 @@ jobs:
269269
if [[ ${{ matrix.os}} == "bare_metal" ]]; then
270270
bash test/build_size_test.sh "-DCMAKE_TOOLCHAIN_FILE=${toolchain_cmake} -DEXECUTORCH_BUILD_ARM_BAREMETAL=ON"
271271
elif [[ ${{ matrix.os}} == "zephyr-preset" ]]; then
272-
CXXFLAGS=${cxx_flags} cmake --preset zephyr -DCMAKE_INSTALL_PREFIX=cmake-out -Bcmake-out .
272+
CXXFLAGS=${cxx_flags} cmake --preset zephyr -DCMAKE_BUILD_TYPE=Release -DEXECUTORCH_OPTIMIZE_SIZE=ON -DCMAKE_INSTALL_PREFIX=cmake-out -Bcmake-out .
273273
cmake --build cmake-out -j9 --target install --config Release
274274
CXXFLAGS=${cxx_flags} cmake -DARM_TOOLCHAIN_NAME=zephyr -DCMAKE_TOOLCHAIN_FILE=${toolchain_cmake} -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=cmake-out -Bcmake-out/test test
275275
cmake --build cmake-out/test -j9 --config Release

0 commit comments

Comments
 (0)