Update on "stop double-installing ExecuTorch in one-off linux jobs"

Github Executorch · Github Executorch · commit db84935c1935 · 2025-01-10T09:49:27.000-08:00
setup-linux.sh already installs ExecuTorch with XNNPACK (and it passes use-pt-pinned-commit as it should). Differential Revision: [D67996460](https://our.internmc.facebook.com/intern/diff/D67996460/) [ghstack-poisoned]
diff --git a/backends/apple/coreml/CMakeLists.txt b/backends/apple/coreml/CMakeLists.txt
@@ -135,7 +135,7 @@ target_include_directories(
 )
 target_include_directories(coremldelegate PRIVATE ${EXECUTORCH_ROOT}/..)
 target_include_directories(coremldelegate PRIVATE ${EXECUTORCH_ROOT}/runtime/core/portable_type)
-target_compile_definitions(coremldelegate C10_USING_CUSTOM_GENERATED_MACROS)
+target_compile_definitions(coremldelegate PRIVATE C10_USING_CUSTOM_GENERATED_MACROS)
 target_link_libraries(coremldelegate PRIVATE executorch_core)
 
 if(EXECUTORCH_BUILD_DEVTOOLS)

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ target_include_directories(`
`135`	`135`	`)`
`136`	`136`	`target_include_directories(coremldelegate PRIVATE ${EXECUTORCH_ROOT}/..)`
`137`	`137`	`target_include_directories(coremldelegate PRIVATE ${EXECUTORCH_ROOT}/runtime/core/portable_type)`
`138`		`-target_compile_definitions(coremldelegate C10_USING_CUSTOM_GENERATED_MACROS)`
	`138`	`+target_compile_definitions(coremldelegate PRIVATE C10_USING_CUSTOM_GENERATED_MACROS)`
`139`	`139`	`target_link_libraries(coremldelegate PRIVATE executorch_core)`
`140`	`140`
`141`	`141`	`if(EXECUTORCH_BUILD_DEVTOOLS)`