Update on "[ET-VK] 7/n Split dispatches between multiple command buffers. Split execute dispatch into multiple commands based on dispatch count."

trivedivivek · trivedivivek · commit dfc80d0da076 · 2025-08-03T21:47:45.000-07:00
Differential Revision: [D78360039](https://our.internmc.facebook.com/intern/diff/D78360039/) [ghstack-poisoned]
diff --git a/backends/vulkan/runtime/graph/ComputeGraph.cpp b/backends/vulkan/runtime/graph/ComputeGraph.cpp
@@ -153,7 +153,7 @@ ComputeGraph::ComputeGraph(GraphConfig config)
   }
   if (config_.execute_threshold_node_count == 0) {
     config_.execute_threshold_node_count = 128;
-    config_.prepack_initial_threshold_nbytes = 64;
+    config_.execute_initial_threshold_node_count = 64;
   }
 }
 
@@ -866,9 +866,10 @@ void ComputeGraph::execute() {
       // execute_initial_threshold_node_count or if its a multiple of
       // execute_threshold_node_count.
       const bool reached_threshold =
-          (encoded_node_count - config_.execute_initial_threshold_node_count) %
+      encoded_node_count >= config_.execute_initial_threshold_node_count &&
+          ((encoded_node_count - config_.execute_initial_threshold_node_count) %
               config_.execute_threshold_node_count ==
-          0;
+          0);
 
       // Create a new command buffer when threashold is reached
       if (reached_threshold) {

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ ComputeGraph::ComputeGraph(GraphConfig config)`
`153`	`153`	`}`
`154`	`154`	`if (config_.execute_threshold_node_count == 0) {`
`155`	`155`	`config_.execute_threshold_node_count = 128;`
`156`		`- config_.prepack_initial_threshold_nbytes = 64;`
	`156`	`+ config_.execute_initial_threshold_node_count = 64;`
`157`	`157`	`}`
`158`	`158`	`}`
`159`	`159`
`@@ -866,9 +866,10 @@ void ComputeGraph::execute() {`
`866`	`866`	`// execute_initial_threshold_node_count or if its a multiple of`
`867`	`867`	`// execute_threshold_node_count.`
`868`	`868`	`const bool reached_threshold =`
`869`		`- (encoded_node_count - config_.execute_initial_threshold_node_count) %`
	`869`	`+ encoded_node_count >= config_.execute_initial_threshold_node_count &&`
	`870`	`+ ((encoded_node_count - config_.execute_initial_threshold_node_count) %`
`870`	`871`	`config_.execute_threshold_node_count ==`
`871`		`- 0;`
	`872`	`+ 0);`
`872`	`873`
`873`	`874`	`// Create a new command buffer when threashold is reached`
`874`	`875`	`if (reached_threshold) {`