Skip to content

Commit e0b6210

Browse files
committed
Fail the benchmark job if the export step fails
1 parent 88a06ef commit e0b6210

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

.github/workflows/android-perf.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ on:
2020
description: Models to be benchmarked
2121
required: false
2222
type: string
23-
default: stories110M
23+
default: llama
2424
devices:
2525
description: Target devices to run benchmark
2626
required: false
@@ -36,7 +36,7 @@ on:
3636
description: Models to be benchmarked
3737
required: false
3838
type: string
39-
default: stories110M
39+
default: llama
4040
devices:
4141
description: Target devices to run benchmark
4242
required: false
@@ -173,6 +173,9 @@ jobs:
173173
upload-artifact-to-s3: true
174174
secrets-env: EXECUTORCH_HF_TOKEN
175175
script: |
176+
# TESTING
177+
exit 1
178+
176179
# The generic Linux job chooses to use base env, not the one setup by the image
177180
echo "::group::Setting up dev environment"
178181
CONDA_ENV=$(conda env list --json | jq -r ".envs | .[-1]")

.github/workflows/apple-perf.yml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ on:
2020
description: Models to be benchmarked
2121
required: false
2222
type: string
23-
default: stories110M
23+
default: llama
2424
devices:
2525
description: Target devices to run benchmark
2626
required: false
@@ -36,7 +36,7 @@ on:
3636
description: Models to be benchmarked
3737
required: false
3838
type: string
39-
default: stories110M
39+
default: llama
4040
devices:
4141
description: Target devices to run benchmark
4242
required: false
@@ -175,6 +175,9 @@ jobs:
175175
script: |
176176
set -eux
177177
178+
# TESTING
179+
exit 1
180+
178181
echo "::group::Setting up CI environment"
179182
.ci/scripts/setup-conda.sh
180183

extension/benchmark/android/benchmark/android-llm-device-farm-test-spec.yml.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ phases:
1212
- echo "The benchmark config is {{ benchmark_config_id }}"
1313

1414
# Download the model from S3
15-
- curl -s --fail '{{ model_path }}' -o model.zip
15+
- curl -s --fail '{{ model_path }}' -o model.zip || false
1616
- unzip model.zip && ls -la
1717

1818
# Copy the model to sdcard. This prints too much progress info when the files

extension/benchmark/apple/Benchmark/default-ios-device-farm-appium-test-spec.yml.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ phases:
1414
- echo "The benchmark config is {{ benchmark_config_id }}"
1515

1616
# Download the model from S3
17-
- curl -s --fail '{{ model_path }}' -o model.zip
17+
- curl -s --fail '{{ model_path }}' -o model.zip || false
1818
- unzip model.zip && ls -la
1919

2020
# Extract the app

0 commit comments

Comments
 (0)