wip ∫ MAY 20 2025 16:19:09

jathu · jathu · commit e6635ab86fea · 2025-05-21T13:53:06.000-07:00
diff --git a/.github/workflows/build-presets.yml b/.github/workflows/build-presets.yml
@@ -66,3 +66,24 @@ jobs:
         ./install_requirements.sh > /dev/null
         cmake --preset ${{ matrix.preset }}
         cmake --build cmake-out --parallel
+
+  windows:
+    uses: pytorch/test-infra/.github/workflows/windows_job.yml@main
+    strategy:
+      fail-fast: false
+      matrix:
+        preset: [pybind]
+    with:
+      job-name: build
+      ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
+      submodules: recursive
+      timeout: 90
+      script: |
+        set -eux
+
+        conda create --yes --quiet -n et python=3.12
+        conda activate et
+
+        ./install_requirements.sh > /dev/null
+        cmake --preset ${{ matrix.preset }}
+        cmake --build cmake-out --parallel
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -260,7 +260,7 @@ if(EXECUTORCH_BUILD_TESTS)
 endif()
 
 # TODO(dbort): Fix these warnings and remove this flag.
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 
 # Let files say "include <executorch/path/to/header.h>".
 # TODO(#6475): This requires/assumes that the repo lives in a directory named
@@ -622,7 +622,7 @@ if(EXECUTORCH_BUILD_PYBIND)
 
   # compile options for pybind
   set(_pybind_compile_options
-      -Wno-deprecated-declarations
+      
       -fPIC
       -frtti
       -fexceptions
diff --git a/backends/apple/mps/CMakeLists.txt b/backends/apple/mps/CMakeLists.txt
@@ -18,7 +18,7 @@ endif()
 
 include(${EXECUTORCH_ROOT}/tools/cmake/Utils.cmake)
 
-set(_common_compile_options -Wno-deprecated-declarations)
+set(_common_compile_options )
 set(_common_include_directories ${EXECUTORCH_ROOT}/..)
 
 set(_mps_schema__include_dir "${CMAKE_BINARY_DIR}/schema/include")
diff --git a/backends/cadence/CMakeLists.txt b/backends/cadence/CMakeLists.txt
@@ -30,7 +30,7 @@ add_compile_definitions(C10_USING_CUSTOM_GENERATED_MACROS)
 if(EXECUTORCH_CADENCE_CPU_RUNNER)
   include(${EXECUTORCH_ROOT}/tools/cmake/Codegen.cmake)
 
-  set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+  set(_common_compile_options  -fPIC)
 
   # Find prebuilt libraries. executorch package should contain portable_ops_lib,
   # etdump, bundled_program.
diff --git a/backends/qualcomm/CMakeLists.txt b/backends/qualcomm/CMakeLists.txt
@@ -261,7 +261,7 @@ if(${CMAKE_SYSTEM_PROCESSOR} MATCHES "x86_64")
 
   if(CMAKE_BUILD_TYPE STREQUAL "Release")
     # need to allow exceptions in pybind
-    set(_pybind_compile_options -Wno-deprecated-declarations -fPIC -frtti
+    set(_pybind_compile_options  -fPIC -frtti
                                 -fexceptions
     )
     target_compile_options(
diff --git a/backends/xnnpack/CMakeLists.txt b/backends/xnnpack/CMakeLists.txt
@@ -36,7 +36,7 @@ if(EXECUTORCH_XNNPACK_ENABLE_KLEIDI)
 endif()
 
 set(_common_include_directories ${EXECUTORCH_ROOT}/..)
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 
 set(_xnnpack_schema__include_dir "${CMAKE_BINARY_DIR}/schema/include")
 # Paths to headers generated from the .fbs files.
diff --git a/configurations/CMakeLists.txt b/configurations/CMakeLists.txt
@@ -18,7 +18,7 @@ endif()
 
 include(${EXECUTORCH_ROOT}/tools/cmake/Utils.cmake)
 
-set(_common_compile_options -Wno-deprecated-declarations)
+set(_common_compile_options )
 
 include(${EXECUTORCH_ROOT}/tools/cmake/Utils.cmake)
 include(${EXECUTORCH_ROOT}/tools/cmake/Codegen.cmake)
diff --git a/examples/apple/mps/CMakeLists.txt b/examples/apple/mps/CMakeLists.txt
@@ -33,7 +33,7 @@ add_compile_options("-Wall" "-Werror")
 
 include(${EXECUTORCH_ROOT}/tools/cmake/Utils.cmake)
 
-set(_common_compile_options -Wno-deprecated-declarations -fPIC
+set(_common_compile_options  -fPIC
                             -DET_EVENT_TRACER_ENABLED
 )
 
diff --git a/examples/arm/CMakeLists.txt b/examples/arm/CMakeLists.txt
@@ -27,7 +27,7 @@ if(NOT PYTHON_EXECUTABLE)
   resolve_python_executable()
 endif()
 
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 
 # Let files say "include <executorch/path/to/header.h>".
 set(_common_include_directories ${EXECUTORCH_ROOT}/..)
diff --git a/examples/devtools/CMakeLists.txt b/examples/devtools/CMakeLists.txt
@@ -29,7 +29,7 @@ if(NOT PYTHON_EXECUTABLE)
   resolve_python_executable()
 endif()
 
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 
 # Let files say "include <executorch/path/to/header.h>".
 set(_common_include_directories ${EXECUTORCH_ROOT}/..)
diff --git a/examples/mediatek/CMakeLists.txt b/examples/mediatek/CMakeLists.txt
@@ -26,7 +26,7 @@ if(NOT PYTHON_EXECUTABLE)
   resolve_python_executable()
 endif()
 
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 
 # Let files say "include <executorch/path/to/header.h>".
 set(_common_include_directories ${EXECUTORCH_ROOT}/..)
diff --git a/examples/models/llama/CMakeLists.txt b/examples/models/llama/CMakeLists.txt
@@ -63,7 +63,7 @@ else()
   set(CMAKE_TOOLCHAIN_IOS OFF)
 endif()
 
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 
 # Let files say "include <executorch/path/to/header.h>".
 set(_common_include_directories ${EXECUTORCH_ROOT}/..)
diff --git a/examples/models/llava/CMakeLists.txt b/examples/models/llava/CMakeLists.txt
@@ -61,7 +61,7 @@ else()
   set(CMAKE_TOOLCHAIN_IOS OFF)
 endif()
 
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 
 # Let files say "include <executorch/path/to/header.h>".
 set(_common_include_directories ${EXECUTORCH_ROOT}/..)
diff --git a/examples/portable/custom_ops/CMakeLists.txt b/examples/portable/custom_ops/CMakeLists.txt
@@ -34,7 +34,7 @@ if(NOT PYTHON_EXECUTABLE)
   resolve_python_executable()
 endif()
 
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 
 # Let files say "include <executorch/path/to/header.h>".
 set(_common_include_directories ${EXECUTORCH_ROOT}/..)
diff --git a/examples/qualcomm/CMakeLists.txt b/examples/qualcomm/CMakeLists.txt
@@ -32,7 +32,7 @@ find_package(executorch CONFIG REQUIRED)
 target_compile_options(executorch INTERFACE -DET_EVENT_TRACER_ENABLED)
 find_package(gflags REQUIRED)
 
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 
 # Let files say "include <executorch/path/to/header.h>".
 set(_common_include_directories ${EXECUTORCH_ROOT}/.. ${EXECUTORCH_ROOT}/extension/llm/tokenizers/third-party/json/single_include)
diff --git a/examples/selective_build/CMakeLists.txt b/examples/selective_build/CMakeLists.txt
@@ -33,7 +33,7 @@ if(NOT CMAKE_CXX_STANDARD)
   # Can't set to 11 due to executor_runner.cpp make_unique
 endif()
 
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 
 # Let files say "include <executorch/path/to/header.h>".
 set(_common_include_directories ${EXECUTORCH_ROOT}/..)
diff --git a/exir/backend/test/demos/rpc/CMakeLists.txt b/exir/backend/test/demos/rpc/CMakeLists.txt
@@ -24,7 +24,7 @@ include(${EXECUTORCH_ROOT}/tools/cmake/Test.cmake)
 include(${EXECUTORCH_ROOT}/tools/cmake/Utils.cmake)
 
 set(_common_include_directories ${EXECUTORCH_ROOT}/..)
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 
 add_library(
   executor_backend STATIC ExecutorBackendRegister.cpp ExecutorBackend.cpp
diff --git a/extension/android/CMakeLists.txt b/extension/android/CMakeLists.txt
@@ -18,7 +18,7 @@ endif()
 
 set(EXECUTORCH_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/../..")
 include(${EXECUTORCH_ROOT}/tools/cmake/Utils.cmake)
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 set(_common_include_directories ${EXECUTORCH_ROOT}/..)
 if(NOT ANDROID_PLATFORM)
   set(ANDROID_PLATFORM android-30)
diff --git a/extension/llm/custom_ops/CMakeLists.txt b/extension/llm/custom_ops/CMakeLists.txt
@@ -16,7 +16,7 @@ if(NOT EXECUTORCH_ROOT)
   set(EXECUTORCH_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/../../..)
 endif()
 
-set(_common_compile_options -Wno-deprecated-declarations -fPIC)
+set(_common_compile_options  -fPIC)
 if(CMAKE_SYSTEM_PROCESSOR MATCHES "arm64|aarch64")
   list(APPEND _common_compile_options "-march=armv8.2-a+dotprod")
 endif()
@@ -129,7 +129,7 @@ if(EXECUTORCH_BUILD_KERNELS_CUSTOM_AOT)
   endif()
   target_compile_options(
     custom_ops_aot_lib
-    PUBLIC -Wno-deprecated-declarations -fPIC -frtti -fexceptions
+    PUBLIC  -fPIC -frtti -fexceptions
            ${_common_compile_options}
   )
 
diff --git a/extension/module/CMakeLists.txt b/extension/module/CMakeLists.txt
@@ -30,7 +30,7 @@ endif()
 target_link_libraries(extension_module PRIVATE executorch_core extension_data_loader extension_flat_tensor)
 target_include_directories(extension_module PUBLIC ${EXECUTORCH_ROOT}/..)
 target_compile_options(
-  extension_module PUBLIC -Wno-deprecated-declarations -fPIC
+  extension_module PUBLIC  -fPIC
 )
 
 # Module extension built as a static library. TODO(gjcomer) Remove this target
@@ -41,7 +41,7 @@ target_link_libraries(
 )
 target_include_directories(extension_module_static PUBLIC ${EXECUTORCH_ROOT}/..)
 target_compile_options(
-  extension_module_static PUBLIC -Wno-deprecated-declarations -fPIC
+  extension_module_static PUBLIC  -fPIC
 )
 
 # Install libraries
diff --git a/extension/training/CMakeLists.txt b/extension/training/CMakeLists.txt
@@ -61,7 +61,7 @@ if(EXECUTORCH_BUILD_PYBIND)
   pybind11_add_module(_training_lib SHARED ${CMAKE_CURRENT_SOURCE_DIR}/pybindings/_training_lib.cpp)
 
   target_include_directories(_training_lib PRIVATE ${TORCH_INCLUDE_DIRS})
-  target_compile_options(_training_lib PUBLIC -Wno-deprecated-declarations -fPIC -frtti -fexceptions)
+  target_compile_options(_training_lib PUBLIC  -fPIC -frtti -fexceptions)
   target_link_libraries(_training_lib PRIVATE ${_pybind_training_dep_libs})
 
   install(TARGETS _training_lib
diff --git a/kernels/optimized/CMakeLists.txt b/kernels/optimized/CMakeLists.txt
@@ -21,7 +21,7 @@ if(NOT EXECUTORCH_ROOT)
   set(EXECUTORCH_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/../..)
 endif()
 
-set(_common_compile_options -Wno-deprecated-declarations)
+set(_common_compile_options )
 
 # Note for apple platform we can rely on Accelerate framework Will come back to
 # this
diff --git a/kernels/portable/CMakeLists.txt b/kernels/portable/CMakeLists.txt
@@ -21,7 +21,7 @@ if(NOT EXECUTORCH_ROOT)
   set(EXECUTORCH_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/../..)
 endif()
 
-set(_common_compile_options -Wno-deprecated-declarations)
+set(_common_compile_options )
 
 include(${EXECUTORCH_ROOT}/tools/cmake/Utils.cmake)
 include(${EXECUTORCH_ROOT}/tools/cmake/Codegen.cmake)
diff --git a/kernels/portable/cpu/util/CMakeLists.txt b/kernels/portable/cpu/util/CMakeLists.txt
@@ -21,7 +21,7 @@ endif()
 
 list(TRANSFORM _kernels_util_all_deps__srcs PREPEND "${EXECUTORCH_ROOT}/")
 
-set(_common_compile_options -Wno-deprecated-declarations)
+set(_common_compile_options )
 
 add_library(kernels_util_all_deps ${_kernels_util_all_deps__srcs})
 target_link_libraries(kernels_util_all_deps PRIVATE executorch_core)
diff --git a/kernels/quantized/CMakeLists.txt b/kernels/quantized/CMakeLists.txt
@@ -20,7 +20,7 @@ if(NOT EXECUTORCH_ROOT)
   set(EXECUTORCH_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/../..)
 endif()
 
-set(_common_compile_options -Wno-deprecated-declarations)
+set(_common_compile_options )
 
 include(${EXECUTORCH_ROOT}/tools/cmake/Utils.cmake)
 include(${EXECUTORCH_ROOT}/tools/cmake/Codegen.cmake)

Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,7 @@ if(${CMAKE_SYSTEM_PROCESSOR} MATCHES "x86_64")`
`261`	`261`
`262`	`262`	`if(CMAKE_BUILD_TYPE STREQUAL "Release")`
`263`	`263`	`# need to allow exceptions in pybind`
`264`		`- set(_pybind_compile_options -Wno-deprecated-declarations -fPIC -frtti`
	`264`	`+ set(_pybind_compile_options -fPIC -frtti`
`265`	`265`	`-fexceptions`
`266`	`266`	`)`
`267`	`267`	`target_compile_options(`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ add_compile_options("-Wall" "-Werror")`
`33`	`33`
`34`	`34`	`include(${EXECUTORCH_ROOT}/tools/cmake/Utils.cmake)`
`35`	`35`
`36`		`-set(_common_compile_options -Wno-deprecated-declarations -fPIC`
	`36`	`+set(_common_compile_options -fPIC`
`37`	`37`	`-DET_EVENT_TRACER_ENABLED`
`38`	`38`	`)`
`39`	`39`