Skip to content

Commit eb6d1cb

Browse files
committed
[ExecuTorch] Remove PATTERNLINT suppressions
Pull Request resolved: #6692 The linter these are suppressing was removed in D63859186. ghstack-source-id: 253169885 Differential Revision: [D65507718](https://our.internmc.facebook.com/intern/diff/D65507718/)
1 parent dc41596 commit eb6d1cb

File tree

10 files changed

+2
-17
lines changed

10 files changed

+2
-17
lines changed

extension/llm/custom_ops/op_sdpa.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
#include <executorch/runtime/core/exec_aten/util/scalar_type_util.h>
1717

1818
#include <array>
19-
// patternlint-disable-next-line executorch-cpp-nostdinc
2019
#include <vector>
2120

2221
#ifdef ET_USE_THREADPOOL

extension/llm/runner/image.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@
99
// A simple image struct.
1010

1111
#pragma once
12-
#include <cstdint>
13-
// patternlint-disable-next-line executorch-cpp-nostdinc
1412
#include <executorch/runtime/platform/compiler.h>
13+
#include <cstdint>
1514
#include <vector>
1615

1716
namespace executorch {

extension/llm/runner/multimodal_runner.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,10 @@
1313
#pragma once
1414

1515
#include <cstdint>
16-
// patternlint-disable-next-line executorch-cpp-nostdinc
1716
#include <functional>
1817
#include <memory>
19-
// patternlint-disable-next-line executorch-cpp-nostdinc
2018
#include <string>
2119
#include <type_traits>
22-
// patternlint-disable-next-line executorch-cpp-nostdinc
2320
#include <unordered_map>
2421

2522
#include <executorch/extension/llm/runner/image.h>

extension/llm/runner/stats.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
#include <executorch/runtime/platform/log.h>
1313
#include <cinttypes>
1414
#include <sstream>
15-
// patternlint-disable-next-line executorch-cpp-nostdinc
1615
#include <string>
1716

1817
namespace executorch {

extension/llm/runner/text_decoder_runner.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include <executorch/extension/module/module.h>
1515
#include <executorch/extension/tensor/tensor.h>
1616
#include <executorch/runtime/platform/compiler.h>
17-
// patternlint-disable-next-line executorch-cpp-nostdinc
1817
#include <functional>
1918

2019
namespace executorch {

extension/llm/runner/text_prefiller.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313

1414
#include <executorch/extension/llm/runner/text_decoder_runner.h>
1515
#include <executorch/extension/llm/tokenizer/tokenizer.h>
16-
// patternlint-disable-next-line executorch-cpp-nostdinc
1716
#include <functional>
1817

1918
namespace executorch {

extension/llm/tokenizer/tokenizer.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@
99
#pragma once
1010

1111
#include <cinttypes>
12-
// patternlint-disable-next-line executorch-cpp-nostdinc
1312
#include <string>
14-
// patternlint-disable-next-line executorch-cpp-nostdinc
1513
#include <vector>
1614

1715
#include <executorch/runtime/core/error.h>

extension/parallel/thread_parallel.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
#pragma once
1010

1111
#include <cstdint>
12-
// @nolint PATTERNLINT Ok to use stdlib for this optional library
1312
#include <functional>
1413

1514
namespace executorch {

kernels/optimized/vec/vec_base.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
#pragma once
22

3-
// @nolint PATTERNLINT <functional> is required for std::equal_to, etc.
4-
53
#include <cassert>
64
#include <cstdint>
75
#include <cstring>

runtime/core/exec_aten/testing_util/tensor_factory.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,8 @@
1414
#ifdef USE_ATEN_LIB
1515
#include <ATen/ATen.h>
1616
#else // !USE_ATEN_LIB
17-
#include <numeric>
18-
// @nolint PATTERNLINT Ok to use stdlib for this test framework
1917
#include <memory>
20-
// @nolint PATTERNLINT Ok to use stdlib for this test framework
18+
#include <numeric>
2119
#include <vector>
2220
#endif // !USE_ATEN_LIB
2321

0 commit comments

Comments
 (0)