Update review comments

Author: mansnils

.ci/scripts/setup-arm-baremetal-tools.sh

@@ -1,5 +1,5 @@
 #!/bin/bash
-# Copyright 2024-2025 Arm Limited and/or its affiliates.
+# Copyright 2024 Arm Limited and/or its affiliates.
 #
 # This source code is licensed under the BSD-style license found in the
 # LICENSE file in the root directory of this source tree.
@@ -9,5 +9,3 @@
 git config --global user.email "[email protected]"
 git config --global user.name "Github Executorch"
 bash examples/arm/setup.sh --i-agree-to-the-contained-eula
-
-./examples/models/llama3_2_vision/install_requirements.sh

backends/arm/operators/op_slice.py

@@ -33,7 +33,8 @@ def define_node(
     ) -> None:
 
         # See slice_copy_support.py
-        assert len(inputs) == 4 or (len(inputs) == 5 and inputs[4].number == 1)
+        if not (len(inputs) == 4 or (len(inputs) == 5 and inputs[4].number == 1)):
+            raise ValueError("Unsupported combination of inputs")
 
         # aten.slice_copy supports slicing in 1d at a time.
         # The arguments are the actual input, dimension of slicing, start index, end index and optinal step or stride.

backends/arm/test/models/test_llama.py

@@ -20,7 +20,6 @@
     get_llama_model,
 )
 
-from executorch.exir import EdgeCompileConfig
 
 # Add project dir to sys path to workaround importlib.import_module() conditions in model_factory.py
 this_files_dir = os.path.dirname(os.path.abspath(__file__))
@@ -38,11 +37,6 @@ class TestLlama(unittest.TestCase):
     Example: --llama_inputs stories110M/stories110M.pt stories110M/params.json
     """
 
-    _edge_compile_config: EdgeCompileConfig = EdgeCompileConfig(
-        _check_ir_validity=False,
-        _skip_dim_order=True,  # TODO(T182928844): Delegate dim order op to backend.
-    )
-
     def prepare_model(self):
 
         checkpoint = None
@@ -117,12 +111,10 @@ def test_llama_tosa_MI(self):
                     constant_methods=llama_meta,
                 )
                 .export()
-                .to_edge_transform_and_lower(
-                    edge_compile_config=self._edge_compile_config
-                )
+                .to_edge_transform_and_lower()
                 .check_count({"torch.ops.higher_order.executorch_call_delegate": 14})
                 .to_executorch()
                 .run_method_and_compare_outputs(
-                    inputs=llama_inputs, atol=1.8, rtol=0.01
+                    inputs=llama_inputs, atol=1.8, rtol=0.01  # TODO: decrease tolerance
                 )
             )

backends/arm/test/test_arm_baremetal.sh

@@ -37,7 +37,7 @@ fi
 TEST_SUITE_NAME="$(basename "$0") ${TEST_SUITE}"
 
 all() { # Run all tests
-    # This will list all lines in this file that is starting with test_ remove () { and add this script name in 
+    # This will list all lines in this file that is starting with test_ remove () { and add this script name in
     # front of it and execute it in a sub shell
     # e.g. from this file:
     #
@@ -62,6 +62,9 @@ all() { # Run all tests
 
 test_pytest() { # Test ops and other things
     echo "${TEST_SUITE_NAME}: Run pytest"
+
+    ./examples/models/llama3_2_vision/install_requirements.sh
+
     cd "${et_root_dir}"
     source examples/arm/ethos-u-scratch/setup_path.sh
     backends/arm/scripts/build_quantized_ops_aot_lib.sh
@@ -74,6 +77,7 @@ test_pytest() { # Test ops and other things
 test_pytest_ethosu_fvp() { # Same as test_pytest but also sometime verify using Corstone FVP
     echo "${TEST_SUITE_NAME}: Run pytest with fvp"
 
+    ./examples/models/llama3_2_vision/install_requirements.sh
     source examples/arm/ethos-u-scratch/setup_path.sh
 
     # Prepare Corstone-3x0 FVP for pytest
@@ -107,7 +111,7 @@ test_run_ethosu_fvp() { # End to End model tests using run.sh
     echo "${TEST_SUITE_NAME}: PASS"
     }
 
-test_models_ethosu_fvp() { # End to End model tests using model_test.py 
+test_models_ethosu_fvp() { # End to End model tests using model_test.py
     echo "${TEST_SUITE_NAME}: Test ethos-u delegate models with test_model.py"
 
     source examples/arm/ethos-u-scratch/setup_path.sh