Skip to content

Commit ee638a9

Browse files
committed
Update on "[ET-VK] Replace Uniform buffers with push constants for copy op"
This diff replaces uniform buffers with push constants for copy op in the Vulkan backend of Executorch. The changes include updating the GLSL code to use push constants instead of uniform buffers and updating the C++ code to pass the sizes as push constants to the shader. Differential Revision: [D66890851](https://our.internmc.facebook.com/intern/diff/D66890851/) [ghstack-poisoned]
2 parents da94739 + 0fb6275 commit ee638a9

File tree

1 file changed

+3
-3
lines changed
  • backends/vulkan/runtime/graph/ops/impl

1 file changed

+3
-3
lines changed

backends/vulkan/runtime/graph/ops/impl/Copy.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,9 @@ void add_copy_offset_node(
5252
nullptr,
5353
{},
5454
{
55-
PushConstantDataInfo(&range, sizeof(utils::ivec4)),
56-
PushConstantDataInfo(&src_offset, sizeof(utils::ivec4)),
57-
PushConstantDataInfo(&dst_offset, sizeof(utils::ivec4)),
55+
PushConstantDataInfo(&range, sizeof(range)),
56+
PushConstantDataInfo(&src_offset, sizeof(src_offset)),
57+
PushConstantDataInfo(&dst_offset, sizeof(dst_offset)),
5858
}));
5959
}
6060

0 commit comments

Comments
 (0)