Skip to content

Commit f0368db

Browse files
authored
Enforce range setting only used with per-channel (#13889)
Differential Revision: D81537565
1 parent 8f724e0 commit f0368db

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

examples/qualcomm/oss_scripts/llama/range_setting_pt2e.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -210,12 +210,13 @@ def make_custom_quantizer(
210210
per_channel_linear=True,
211211
act_observer=MinMaxObserver,
212212
)
213-
if range_setting in ("mse_weight_only", "mse_with_act_loss", "na"):
214-
if range_setting == "na":
215-
observer = PerChannelMinMaxObserver
216-
elif range_setting == "mse_weight_only":
213+
if range_setting in ("mse_weight_only", "mse_with_act_loss"):
214+
assert (
215+
quant_dtype != QuantDtype.use_16a4w_block
216+
), "Range setting only supported for per-channel quantization"
217+
if range_setting == "mse_weight_only":
217218
observer = PerChannelMSEObserver.with_args(
218-
**{"steps": 200, "use_mse": True}
219+
**{"steps": 1600, "use_mse": True}
219220
)
220221
else:
221222
observer = PerChannelFixedQParamsObserver.with_args(**{"eps": 2**-12})

0 commit comments

Comments
 (0)