Skip to content

Commit f34efca

Browse files
authored
Shift Left: Build and test extension/llm/... buck packages packages whenever possible (#14542)
We had a few reverts last week's oncall. Having these in place would have prevented them. Test Plan: unittest-buck CI job
1 parent 25b3d63 commit f34efca

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

.ci/scripts/unittest-buck2.sh

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,17 @@ BUILDABLE_KERNELS_PRIM_OPS_TARGETS=$(buck2 query //kernels/prim_ops/... | grep -
3535
for op in "build" "test"; do
3636
buck2 $op $BUILDABLE_OPTIMIZED_OPS \
3737
//examples/selective_build:select_all_dtype_selective_lib_portable_lib \
38+
//extension/llm/custom_ops/spinquant/test:fast_hadamard_transform_test \
39+
//extension/llm/runner/test:test_multimodal_input \
40+
//extension/llm/runner/test:test_generation_config \
3841
//kernels/portable/... \
3942
$BUILDABLE_KERNELS_PRIM_OPS_TARGETS //runtime/backend/... //runtime/core/... \
4043
//runtime/executor: //runtime/kernel/... //runtime/platform/...
4144
done
4245

4346
# Build only without testing
44-
buck2 build //codegen/tools/... # Needs torch for testing which we don't have in our OSS buck setup.
47+
buck2 build //codegen/tools/... \
48+
//extension/llm/runner/io_manager:io_manager \
49+
//extension/llm/modules/... \
50+
//extension/llm/runner:multimodal_runner_lib \
51+
//extension/llm/runner:text_decoder_runner

.lintrunner.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@ exclude_patterns = [
206206
'**/*.png',
207207
'**/*.webp',
208208
'**/*.jpeg',
209+
'**/*.mp3',
209210
'**/*.mp4',
210211
'**/*.pte',
211212
'**/*.pth',
@@ -216,6 +217,8 @@ exclude_patterns = [
216217
'**/*.jpg',
217218
'**/*.jar',
218219
'**/*.gif',
220+
'extension/llm/tokenizers',
221+
'extension/llm/tokenizers/**',
219222
# File contains @generated
220223
'extension/llm/custom_ops/spinquant/fast_hadamard_transform_special.h',
221224
'extension/llm/custom_ops/spinquant/test/fast_hadamard_transform_special_unstrided_cpu.h',

0 commit comments

Comments
 (0)