Skip to content

Commit f494863

Browse files
committed
Remove other extensions' source files from EXTENSION_TRAINING_SRCS and TRAIN_XOR_SRCS
Looks like this was an artifact of improperly specified deps in (now deleted) cmake_deps.toml. extension/training/CMakeLists.txt already has the relevant dependencies, so we should be able to just remove these. ghstack-source-id: 345e5d1 ghstack-comment-id: 3189839323 Pull-Request: #13433
1 parent 12ea3f0 commit f494863

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

shim_et/xplat/executorch/build/build_variables.bzl

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -367,27 +367,14 @@ THREADPOOL_SRCS = [
367367
EXTENSION_THREADPOOL_SRCS = ["extension/threadpool/" + x for x in THREADPOOL_SRCS]
368368

369369
EXTENSION_TRAINING_SRCS = [
370-
"extension/data_loader/file_data_loader.cpp",
371-
"extension/data_loader/mmap_data_loader.cpp",
372-
"extension/flat_tensor/flat_tensor_data_map.cpp",
373-
"extension/flat_tensor/serialize/flat_tensor_header.cpp",
374-
"extension/module/module.cpp",
375370
"extension/training/module/training_module.cpp",
376371
"extension/training/optimizer/sgd.cpp",
377372
]
378373

379374
TRAIN_XOR_SRCS = [
380-
"extension/data_loader/file_data_loader.cpp",
381-
"extension/data_loader/mmap_data_loader.cpp",
382-
"extension/flat_tensor/flat_tensor_data_map.cpp",
383-
"extension/flat_tensor/serialize/flat_tensor_header.cpp",
375+
# REVIEW: removing this breaks the build; where is it supposed to come from?
384376
"extension/flat_tensor/serialize/serialize.cpp",
385-
"extension/module/module.cpp",
386-
"extension/tensor/tensor_ptr.cpp",
387-
"extension/tensor/tensor_ptr_maker.cpp",
388377
"extension/training/examples/XOR/train.cpp",
389-
"extension/training/module/training_module.cpp",
390-
"extension/training/optimizer/sgd.cpp",
391378
]
392379

393380
EXECUTOR_RUNNER_SRCS = [

0 commit comments

Comments
 (0)