Skip to content

Commit f57ca18

Browse files
committed
Update
[ghstack-poisoned]
1 parent 1a6b7a6 commit f57ca18

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

setup.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -237,11 +237,11 @@ def src_path(self, installer: "InstallerBuildExt") -> Path:
237237
srcs = tuple(cmake_cache_dir.glob(self.src))
238238
if len(srcs) != 1:
239239
raise ValueError(
240-
f"""Expected exactly one file matching '{self.src}'; found {repr(srcs)}.
240+
f"""Expected exactly one file matching '{self.src}'; found {repr(srcs)}.
241241
242242
If that file is a CMake-built extension module file, and we are installing in editable mode, please disable the corresponding build option since it's not supported yet.
243243
244-
Try:
244+
Try:
245245
246246
EXECUTORCH_BUILD_FLATC=OFF EXECUTORCH_BUILD_KERNELS_CUSTOM_AOT=OFF pip install -e .
247247
"""
@@ -611,9 +611,9 @@ def run(self):
611611
# for multi-config generators.
612612
build_args += ["--config", cfg]
613613

614-
# Put the cmake cache under the temp directory, like
615-
# "pip-out/temp.<plat>/cmake-out".
616-
cmake_cache_dir = os.path.join(repo_root, self.build_temp, "cmake-out")
614+
# Share the cmake-out directory with any other cmake builds the user/developer
615+
# might do, rather than hiding it under build_temp.
616+
cmake_cache_dir = os.path.join(repo_root, "cmake-out")
617617
self.mkpath(cmake_cache_dir)
618618

619619
# Generate the cmake cache from scratch to ensure that the cache state

0 commit comments

Comments
 (0)