Dont require method loading for meta meta in module api

JacobSzwejbka · facebook-github-bot · commit f812f762eecc · 2025-06-09T11:00:11.000-07:00
Summary: Program load is still required but this is very cheap. Method load is not needed.

Differential Revision: D76278890
diff --git a/extension/module/module.cpp b/extension/module/module.cpp
@@ -229,8 +229,8 @@ runtime::Error Module::load_method(
 
 runtime::Result<MethodMeta> Module::method_meta(
     const std::string& method_name) {
-  ET_CHECK_OK_OR_RETURN_ERROR(load_method(method_name));
-  return methods_.at(method_name).method->method_meta();
+  ET_CHECK_OK_OR_RETURN_ERROR(load());
+  return program_->method_meta(method_name.c_str());
 }
 
 runtime::Result<std::vector<runtime::EValue>> Module::execute(

Original file line number	Diff line number	Diff line change
`@@ -229,8 +229,8 @@ runtime::Error Module::load_method(`
`229`	`229`
`230`	`230`	`runtime::Result<MethodMeta> Module::method_meta(`
`231`	`231`	`const std::string& method_name) {`
`232`		`- ET_CHECK_OK_OR_RETURN_ERROR(load_method(method_name));`
`233`		`- return methods_.at(method_name).method->method_meta();`
	`232`	`+ ET_CHECK_OK_OR_RETURN_ERROR(load());`
	`233`	`+ return program_->method_meta(method_name.c_str());`
`234`	`234`	`}`
`235`	`235`
`236`	`236`	`runtime::Result<std::vector<runtime::EValue>> Module::execute(`