Skip to content

Commit f819120

Browse files
Update on "[ExecuTorch][#10375] Add extension.BundledModule to Wrap extension.Module with Bundled Program Logic"
#10375 # Context This issue is a step of #9638. In #9638, we want to have `extension.Module` as the single source of implementation in `pybindings`, which means that `pybindings.PyModule` should use `extension.Module` rather than its own `pybindings.Module`. The issue is that `pybindings.PyModule` is dependent on the `method` getter from `pybindings.Module`, which `extension.Module` do not have. Since we don't want to expose `method` getter in `extension.Module`, we have to protect the getter, wrap the functions that is dependent on it and use the protected getter there, ultimately decouple `pybindings` from a `method` getter. # Proposal Now that we have a protected `method` getter, we can introduce a `extension.BundledModule`, a child class inheriting `extension.Module` which wraps up bundled program logic that is dependent on the `method` getter. Differential Revision: [D73564125](https://our.internmc.facebook.com/intern/diff/D73564125/) [ghstack-poisoned]
2 parents 053d845 + 2eb05fa commit f819120

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

extension/module/bundled_module.h

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,13 +54,11 @@ class BundledModule : public Module {
5454
}
5555

5656
/**
57-
* Constructs an instance with the bundled program buffer pointer.
58-
*
59-
* This constructor reads the program from bundled program buffer to load the
60-
* module with data loader. The bundled program pointer is preserved so that
61-
* the portion outside of program is accessible.
57+
* Constructs an instance by loading a bundled program from a file with
58+
* specified memory locking behavior.
6259
*
63-
* @param[in] file_path The path to the ExecuTorch program file to load.
60+
* @param[in] file_path The path to the ExecuTorch bundled program file to
61+
* load.
6462
* @param[in] memory_allocator A MemoryAllocator used for memory management.
6563
* @param[in] temp_allocator A MemoryAllocator to use when allocating
6664
* temporary data during kernel or delegate execution.

0 commit comments

Comments
 (0)