Update on "[ET-VK] Introduce no_volk buck targets"

TSIA. Introduce variants of the vulkan backend buck targets that do not use volk.

Differential Revision: [D65827152](https://our.internmc.facebook.com/intern/diff/D65827152/)

[ghstack-poisoned]

Author: SS-JIA

backends/vulkan/runtime/vk_api/Device.h

@@ -27,7 +27,7 @@ struct PhysicalDevice final {
   VkPhysicalDeviceMemoryProperties memory_properties;
 
   // Head of the linked list of extensions to be requested
-  void* extension_features{nullptr};
+  void* extension_features;
 
   // Additional features available from extensions
 #ifdef VK_KHR_16bit_storage

backends/vulkan/targets.bzl

@@ -1,5 +1,8 @@
+load("@fbcode//target_determinator/macros:ci.bzl", "ci")
 load("@fbcode_macros//build_defs:native_rules.bzl", "buck_genrule")
 load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
+load("@fbsource//tools/build_defs:platform_defs.bzl", "ANDROID", "CXX", "FBCODE")
+
 
 def get_vulkan_compiler_flags():
     return ["-Wno-missing-prototypes", "-Wno-global-constructors"]
@@ -43,12 +46,21 @@ def vulkan_spv_shader_lib(name, spv_filegroups, is_fbcode = False, no_volk = Fal
     )
 
     suffix = "_no_volk" if no_volk else ""
+    platforms = [ANDROID, CXX]
+    labels = []
+    if no_volk:
+        platforms = [ANDROID]
+        labels = ci.labels(ci.linux(ci.mode("fbsource//arvr/mode/android/mac/dbg")))
+
+
     runtime.cxx_library(
         name = name,
         srcs = [
             ":{}[{}.cpp]".format(genrule_name, name),
         ],
         compiler_flags = get_vulkan_compiler_flags(),
+        labels = labels,
+        platforms = platforms,
         define_static_target = False,
         # Static initialization is used to register shaders to the global shader registry,
         # therefore link_whole must be True to make sure unused symbols are not discarded.
@@ -91,8 +103,18 @@ def define_common_targets(is_fbcode = False):
     )
 
     for no_volk in [True, False]:
+        # No volk not available for FBCode
+        if no_volk and is_fbcode:
+            continue
+
         suffix = "_no_volk" if no_volk else ""
 
+        platforms = [ANDROID, CXX]
+        labels = []
+        if no_volk:
+            platforms = [ANDROID]
+            labels = ci.labels(ci.linux(ci.mode("fbsource//arvr/mode/android/mac/dbg")))
+
         VK_API_PREPROCESSOR_FLAGS = []
         VK_API_DEPS = [
             "fbsource//third-party/VulkanMemoryAllocator/3.0.1:VulkanMemoryAllocator_xplat",
@@ -148,6 +170,8 @@ def define_common_targets(is_fbcode = False):
                 "runtime/utils/**/*.h",
                 "runtime/vk_api/**/*.h",
             ]),
+            labels = labels,
+            platforms = platforms,
             visibility = [
                 "//executorch/backends/vulkan/...",
                 "@EXECUTORCH_CLIENTS",
@@ -165,6 +189,8 @@ def define_common_targets(is_fbcode = False):
             exported_headers = native.glob([
                 "runtime/graph/**/*.h",
             ]),
+            labels = labels,
+            platforms = platforms,
             visibility = [
                 "//executorch/backends/...",
                 "//executorch/extension/pybindings/...",
@@ -202,6 +228,8 @@ def define_common_targets(is_fbcode = False):
             headers = native.glob([
                 "runtime/*.h",
             ]),
+            labels = labels,
+            platforms = platforms,
             visibility = [
                 "//executorch/backends/...",
                 "//executorch/extension/pybindings/...",

backends/vulkan/test/compute_api_tests.bzl

@@ -1,6 +1,7 @@
+load("@fbcode//target_determinator/macros:ci.bzl", "ci")
 load("@fbsource//tools/build_defs:fb_xplat_cxx_binary.bzl", "fb_xplat_cxx_binary")
 load("@fbsource//tools/build_defs:fb_xplat_cxx_test.bzl", "fb_xplat_cxx_test")
-load("@fbsource//tools/build_defs:platform_defs.bzl", "ANDROID", "MACOSX")
+load("@fbsource//tools/build_defs:platform_defs.bzl", "ANDROID", "MACOSX", "CXX")
 load(
     "@fbsource//xplat/executorch/backends/vulkan:targets.bzl",
     "vulkan_spv_shader_lib",
@@ -9,6 +10,12 @@ load(
 def define_compute_api_test_targets():
     for no_volk in [True, False]:
         suffix = "_no_volk" if no_volk else ""
+        platforms = [ANDROID, CXX]
+        labels = []
+        if no_volk:
+            platforms = [ANDROID]
+            labels = ci.labels(ci.linux(ci.mode("fbsource//arvr/mode/android/mac/dbg")))
+
         vulkan_spv_shader_lib(
             name = "test_shader_lib{}".format(suffix),
             spv_filegroups = {
@@ -27,6 +34,8 @@ def define_compute_api_test_targets():
                 "utils/test_utils.h",
             ],
             apple_sdks = MACOSX,
+            labels = labels,
+            platforms = platforms,
             visibility = ["PUBLIC"],
             deps = [
                 ":test_shader_lib{}".format(suffix),