Commit fb9a7e3
Fix build_apple_frameworks.sh to use proper EXECUTORCH_ENABLE_LOGGING… (#12473)
EXECUTORCH_ENABLE_LOGGING doesn't pick up based on the build mode, as it
should based on
[default.cmake](https://github.com/pytorch/executorch/blob/main/tools/cmake/preset/default.cmake#L20)
Meanwhile macOS preset in macos.cmake always enabled logging due to the
fact it includes
[pybind.cmake](https://github.com/pytorch/executorch/blob/main/tools/cmake/preset/pybind.cmake#L10-L13)
which deliberately enables it with an override.
Thus for Apple frameworks build we get logging disabled permanently,
except for macos where it's always enabled based on a pretty unrelated
pybind settings.
Co-authored-by: Anthony Shoumikhin <[email protected]>1 parent 16a6585 commit fb9a7e3
1 file changed
+3
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
148 | 148 | | |
149 | 149 | | |
150 | 150 | | |
| 151 | + | |
151 | 152 | | |
152 | 153 | | |
153 | 154 | | |
154 | 155 | | |
| 156 | + | |
| 157 | + | |
155 | 158 | | |
156 | 159 | | |
157 | 160 | | |
| |||
0 commit comments