Skip to content

Commit fbb6145

Browse files
committed
Corrected New Contributor Guide PR merging details
1 parent 91a14f1 commit fbb6145

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed
166 KB
Loading
26 KB
Loading

docs/source/new-contributor-guide.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,6 +271,14 @@ Once you've successfully finished local development, it's time to send out your
271271
272272
Those reviewers/maintainers are here to finetune your contribution and eventually catch some issues before we merge the PR. We aim for this process to be pleasing on both sides: we try to give and get the best.
273273
274-
Once the reviewers are happy, one of our core contributors will merge your PR. Congratulations — you're now an official ExecuTorch contributor!
274+
Once the reviewers are happy, they'll approve your PR, indicating that they're happy for it to be merged. This will send you a notification and display as follows on your PR page:
275+
276+
![](./_static/img/new-contributor-guide/pr_approval1.png)
277+
278+
And in the PR comments:
279+
280+
![](./_static/img/new-contributor-guide/pr_approval2.png)
281+
282+
Once you've received the required approval from a core contributor, you can go ahead and merge your PR. Congratulations — you're now an official ExecuTorch contributor!
275283
276284
Great job making it to the end of our guide — we hope you enjoy contributing. Once again, please check out **[Discord Server](https://discord.com/invite/Dh43CKSAdc)** if you want to say hello, ask any questions, or talk about any and all things ExecuTorch. We look forward to receiving your contributions!

0 commit comments

Comments
 (0)