executorch doesn't build if the top-level checkout isn't called exactly `executorch`

[swolchok]

🐛 Describe the bug

Attempt to checkout executorch into a directory with a different name for purposes of cleanly reproing a bug -- git clone -b release/0.4 https://github.com/pytorch/executorch.git executorchinstall && cd executorchinstall. Result: build fails with error about being unable to find headers, because the project makes includes work by adding .. to include directories.

Versions

N/A

[lucylq]

I think this is a known issue, though couldn't find the previous discussions. cc @dbort if you have more context?

[dbort]

It's definitely a pain. Tracked by issue #6475. PR #6480 tries to make the issue more transparent-- did you see that message when you built from the non-executorch path?

CMake Error at CMakeLists.txt:332 (message):
  The ExecuTorch repo must be cloned into a directory named exactly
  `executorch`; found `not-executorch`.  See
  https://github.com/pytorch/executorch/issues/6475 for progress on a fix for
  this restriction.

If not then we should figure out why it didn't show up

[swolchok]

did you see that message when you built from the non-executorch path?

wasn't paying attention, just wanted to flag this issue.