Mimi: sqnr and test without streaming #10004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10004
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit 70b2889 with merge base d28670b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
Contributor
|
@billmguo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@iseeyuan has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Add non-streaming test, and replace the atol with sqnr. Test Plan: python -m unittest examples/models/moshi/mimi/test_mimi.py Differential Revision: D72978040 Pulled By: iseeyuan
facebook-github-bot
force-pushed
the
streaming
branch
from
dc13556 to
70b2889
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72978040 |
billmguo
approved these changes
Apr 14, 2025
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Differential Revision: D72978040 Pull Request resolved: pytorch#10004
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add non-streaming test, and replace the atol with sqnr.
Test plan
python -m unittest examples/models/moshi/mimi/test_mimi.py