Return None as dynamic shape when enable_dynamic_shape is False #10073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larryliu0820
requested review from
iseeyuan,
jackzhxng and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10073
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 4 Cancelled JobsAs of commit 0bf46ae with merge base 7f3b382 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72805966 |
iseeyuan
approved these changes
Apr 10, 2025
Summary: In `LLMEdgeManager`, `self.enable_dynamic_shape = False` means the token dimension is static (always 1). Reviewed By: iseeyuan, jackzhxng Differential Revision: D72805966
facebook-github-bot
force-pushed
the
export-D72805966
branch
from
0fc7383 to
0bf46ae
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D72805966 |
kirklandsign
pushed a commit
that referenced
this pull request
Apr 11, 2025
Differential Revision: D72805966 Pull Request resolved: #10073
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
Differential Revision: D72805966 Pull Request resolved: pytorch#10073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In
LLMEdgeManager,self.enable_dynamic_shape = Falsemeans the token dimension is static (always 1).Differential Revision: D72805966