[arm][ez] Add xfail for norm tests
#10078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ## Context #9938 made it so that `linalg_vector_norm` is now decomposed when exporting to Edge. However, this broke some tests in the arm delegate because export passes cannot handle the decomposed operator sequence. To account for this, add `xfail` for the failing tests since `linalg_vector_norm` is not supported in TOSA yet. ## Changes Add `xfail` for `norm` tests in `test_torch_functions.py` Test Plan: ## Test Plan Check CI that failing test is recovered. (cherry picked from commit f2a08da)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10078
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit e8c289e with merge base 771588a ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Apr 10, 2025
facebook-github-bot
added
the
CLA Signed
metascroy
approved these changes
Apr 10, 2025
Contributor
|
waiting for CI before merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
#9938 made it so that
linalg_vector_normis now decomposed when exporting to Edge. However, this broke some tests in the arm delegate because export passes cannot handle the decomposed operator sequence. To account for this, addxfailfor the failing tests sincelinalg_vector_normis not supported in TOSA yet.Changes
Add
xfailfornormtests intest_torch_functions.pyTest Plan:
Test Plan
Check CI that failing test is recovered.