Update pytorch-labs/tokenizers to 295ee78 #10161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10161
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d4dc679 with merge base 4ea6839 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jathu
requested review from
iseeyuan,
jackzhxng,
larryliu0820 and
swolchok
as code owners
Contributor
|
Hmm why is the submodule showing only 4 files changed? My pin update from the commit prior to yours shows a lot more - https://github.com/pytorch/executorch/pull/10017/files |
Contributor
Author
|
@jackzhxng I'm not sure. I just update the submodule to main (it was using a detached commit meta-pytorch/tokenizers@71167bf). How did you update the submodule? |
jackzhxng
approved these changes
Apr 15, 2025
Contributor
jackzhxng
left a comment
jackzhxng
left a comment
There was a problem hiding this comment.
Mb, should be fine actually after dbl checking the changed files
keyprocedure
pushed a commit
to keyprocedure/executorch
that referenced
this pull request
Apr 21, 2025
### Summary Update tokenizers lib to include meta-pytorch/tokenizers#46. ### Test plan CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update tokenizers lib to include meta-pytorch/tokenizers#46.
Test plan
CI