Skip to content

Conversation

@derekxu
Copy link
Contributor

@derekxu derekxu commented Apr 17, 2025

Differential Revision: D73213645

@pytorch-bot
Copy link

pytorch-bot bot commented Apr 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10280

Note: Links to docs will display an error until the docs builds have been completed.

❌ 72 New Failures

As of commit dde53ca with merge base f911567 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 17, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73213645

@derekxu
Copy link
Contributor Author

derekxu commented Apr 17, 2025

@pytorchbot label "topic: not user facing"

derekxu pushed a commit to derekxu/executorch that referenced this pull request Apr 17, 2025
Summary:

Fix undefined fht_float in Apple OS

- Added the lib source file for default OS
- Other changes are auto-gen by the linter

```
source ~/.bashrc
cd ~/fbsource/fbcode/executorch
conda activate executorch
lintrunner -a
```

Differential Revision: D73213645
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73213645

@larryliu0820
Copy link
Contributor

Can you change the title and description to describe why you make this change?

@derekxu derekxu changed the title Export of D73213645 Fix undefined fht_float in Apple OS Apr 17, 2025
derekxu pushed a commit to derekxu/executorch that referenced this pull request Apr 17, 2025
Summary:

Fix undefined fht_float in Apple OS

- Added the lib source file for default OS: executorch/extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl
- Other changes are auto-gen by the linter

```
source ~/.bashrc
cd ~/fbsource/fbcode/executorch
conda activate executorch
lintrunner -a
```

Differential Revision: D73213645
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73213645

@derekxu
Copy link
Contributor Author

derekxu commented Apr 17, 2025

Can you change the title and description to describe why you make this change?

@larryliu0820 done

derekxu pushed a commit to derekxu/executorch that referenced this pull request Apr 17, 2025
Summary:

Fix undefined fht_float in Apple OS

- Added the lib source file for default OS: executorch/extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl
- Other changes are auto-gen by the linter

```
source ~/.bashrc
cd ~/fbsource/fbcode/executorch
conda activate executorch
lintrunner -a
```

Differential Revision: D73213645
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73213645

derekxu pushed a commit to derekxu/executorch that referenced this pull request Apr 17, 2025
Summary:

Fix undefined fht_float in Apple OS

- Added the lib source file for default OS: executorch/extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl
- Other changes are auto-gen by the linter

```
source ~/.bashrc
cd ~/fbsource/fbcode/executorch
conda activate executorch
lintrunner -a
```

Differential Revision: D73213645
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73213645

Summary:

Fix undefined fht_float in Apple OS

- Added the lib source file for default OS: executorch/extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl
- Other changes are auto-gen by the linter

```
source ~/.bashrc
cd ~/fbsource/fbcode/executorch
conda activate executorch
lintrunner -a
```

Differential Revision: D73213645
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73213645

Comment on lines +22 to +24
"ovr_config//os:iphoneos": ["fht_avx.c"],
"ovr_config//os:macos-x86_64": ["fht_avx.c"],
"ovr_config//os:macos-arm64": ["fht_neon.c"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you explain more about why this is necessary? the added stuff seems redundant with what is already there. also, in particular, fht_avx.c is not the correct implementation on arm64 iOS.

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Sep 1, 2025
@github-actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale PRs inactive for over 60 days topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants