-
Notifications
You must be signed in to change notification settings - Fork 751
Fix undefined fht_float in Apple OS #10280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10280
Note: Links to docs will display an error until the docs builds have been completed. ❌ 72 New FailuresAs of commit dde53ca with merge base f911567 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D73213645 |
|
@pytorchbot label "topic: not user facing" |
Summary: Fix undefined fht_float in Apple OS - Added the lib source file for default OS - Other changes are auto-gen by the linter ``` source ~/.bashrc cd ~/fbsource/fbcode/executorch conda activate executorch lintrunner -a ``` Differential Revision: D73213645
547915e to
5837ce8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73213645 |
|
Can you change the title and description to describe why you make this change? |
Summary: Fix undefined fht_float in Apple OS - Added the lib source file for default OS: executorch/extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl - Other changes are auto-gen by the linter ``` source ~/.bashrc cd ~/fbsource/fbcode/executorch conda activate executorch lintrunner -a ``` Differential Revision: D73213645
5837ce8 to
d1c13de
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73213645 |
@larryliu0820 done |
Summary: Fix undefined fht_float in Apple OS - Added the lib source file for default OS: executorch/extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl - Other changes are auto-gen by the linter ``` source ~/.bashrc cd ~/fbsource/fbcode/executorch conda activate executorch lintrunner -a ``` Differential Revision: D73213645
d1c13de to
b9c7bfa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73213645 |
Summary: Fix undefined fht_float in Apple OS - Added the lib source file for default OS: executorch/extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl - Other changes are auto-gen by the linter ``` source ~/.bashrc cd ~/fbsource/fbcode/executorch conda activate executorch lintrunner -a ``` Differential Revision: D73213645
b9c7bfa to
46b2cfd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73213645 |
Summary: Fix undefined fht_float in Apple OS - Added the lib source file for default OS: executorch/extension/llm/custom_ops/spinquant/third-party/FFHT/targets.bzl - Other changes are auto-gen by the linter ``` source ~/.bashrc cd ~/fbsource/fbcode/executorch conda activate executorch lintrunner -a ``` Differential Revision: D73213645
46b2cfd to
dde53ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73213645 |
| "ovr_config//os:iphoneos": ["fht_avx.c"], | ||
| "ovr_config//os:macos-x86_64": ["fht_avx.c"], | ||
| "ovr_config//os:macos-arm64": ["fht_neon.c"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you explain more about why this is necessary? the added stuff seems redundant with what is already there. also, in particular, fht_avx.c is not the correct implementation on arm64 iOS.
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Differential Revision: D73213645