Arm backend: Remove build_quantized_ops_aot_lib.sh #10350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lib is built by default when installing executorch, so use that instead of building our own version. The the version built by executorch however has an extra dependency on _portable_lib.cpython-310, which needs to be loaded as well. Also removes all mentions of this script in related files. Signed-off-by: Adrian Lundell <[email protected]> Change-Id: Ia3cf9eabb4e293ef96a9cc3441c4233241873684
AdrianLundell
added
partner: arm
AdrianLundell
requested review from
digantdesai and
mergennachin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10350
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit de478c4 with merge base 9663990 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Change-Id: I4fcbbfe125a30e919e899e8add1ff4c8ed140ea5 Signed-off-by: Adrian Lundell <[email protected]>
Instead of defining a new function for loading the quantized_aot_lib, and portable_lib, simply import the module to reuse the logic which is implemented in the __init__ file. By doing this when importing the arm quantizer, we are sure that this lib is loaded when running quantized networks. Signed-off-by: Adrian Lundell <[email protected]> Change-Id: I5ef585981a09d332d15f7001fb97536b1a56def7
Collaborator
Author
|
Unrelated lint failure in unmodified file. |
zingo
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lib is built by default when installing executorch, so use that instead of building our own version. The the version built by executorch however has an extra dependency on _portable_lib.cpython-310, which needs to be loaded as well.
Also removes all mentions of this script in related files.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218