Update module wrapper so that params are explicitly registered to the wrapper #10358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asserts are converted to proper raises to ensure graph integrity. Improve error message. Signed-off-by: Sebastian Larsson <[email protected]> Co-authored-by: Oscar Andersson <[email protected]>
Differential Revision: D73382201 Pull Request resolved: #10331
Differential Revision: D73268792 Pull Request resolved: #10300
…ss (#10137) Update ConvertExpandCopyToRepeatPass to eliminate Repeat nodes where all repetition counts are one, as these are functionally equivalent to a simple copy. This reduces unnecessary operations in the graph. This patch affects two unit tests in backends/arm/test/ops/test_expand.py. The models (test subjects) in those unit tests are in the affected cases optimized such that the only computation node (torch.Tensor.expand) they each contain is optimized away by the modified ConvertExpandCopyToRepeatPass. This will make Vela complain saying that the model is empty and the TOSA file cannot be compiled. Set the affected unit tests to xfail since they are expected to be resolved later in another patch. Co-authored-by: Martin Lindström <[email protected]>
Populate backends/arm/quantizer/__init__.py and backends/arm/__init__.py Signed-off-by: Oscar Andersson <[email protected]>
Differential Revision: D72740782 Pull Request resolved: #10344
Differential Revision: D73418899 Pull Request resolved: #10348
… wrapper Pull Request resolved: #10305 Seeing issue with linear where the fqns for constants disappear. Registering self.method_name as a submodule of wrapper means that the parameters are registered to the wrapper. thanks @angelayi for the fix! ``` File "/data/users/lfq/fbsource/buck-out/v2/gen/fbcode/1af94fa701700343/executorch/test/models/__export_delegated_program__/export_delegated_program#link-tree/torch/export/_trace.py", line 1980, in _export_for_training export_artifact = export_func( File "/data/users/lfq/fbsource/buck-out/v2/gen/fbcode/1af94fa701700343/executorch/test/models/__export_delegated_program__/export_delegated_program#link-tree/torch/export/_trace.py", line 1473, in _strict_export _replace_param_buffer_names(param_buffer_table, export_graph_signature) File "/data/users/lfq/fbsource/buck-out/v2/gen/fbcode/1af94fa701700343/executorch/test/models/__export_delegated_program__/export_delegated_program#link-tree/torch/export/_trace.py", line 272, in _replace_param_buffer_names spec.target = param_buffer_table[spec.target] KeyError: 'L__self___fn___self___linear.weight' ``` ghstack-source-id: 279346028 @exported-using-ghexport Differential Revision: [D73279618](https://our.internmc.facebook.com/intern/diff/D73279618/)
lucylq
requested review from
Gasoonjia,
cccclai,
digantdesai,
jackzhxng,
kirklandsign,
larryliu0820 and
tarun292
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10358
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #10305 by @lucylq
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/61/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/61/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/lucylq/60/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/lucylq/61/orig
@diff-train-skip-merge