Arm backend: Fix CPU cycle counters over backend delegate code #10393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zingo Andersen <[email protected]> Change-Id: I3c688d2c5227cfce81ed391db4b84fd28a49b6b2
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10393
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit c6bfdef with merge base a0ca486 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
zingo
added
partner: arm
oscarandersson8218
approved these changes
Apr 24, 2025
Collaborator
Author
|
Linerror unrelated |
zingo
deleted the
Arm-backend-Fix-CPU-cycle-counters-over-backend-delegate-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug where we renamed the weak functions but not the non-weak versions.
Test plan
Tests by looking at the logs when running and detecting that cycles was not zero.
cc @digantdesai @freddan80 @per @oscarandersson8218