Skip to content

Fix numel() downcast in dper_lib/silvertorch/core/legacy/tools/eval/tests/TestUtil.cpp +2 #10420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix numel() downcast in dper_lib/silvertorch/core/legacy/tools/eval/tests/TestUtil.cpp +2 #10420

wants to merge 1 commit into from

Conversation

@r-barnes
Copy link
Contributor

@r-barnes r-barnes commented Apr 23, 2025

Summary: numel() has type int64_t. The implicit downcasts fix in this change artificially truncate data ranges which can lead to hard-to-debug errors and SEVs. Using auto ensures that the correct data type is used.

Reviewed By: dtolnay

Differential Revision: D73533979

@r-barnes @facebook-github-bot
Fix numel() downcast in dper_lib/silvertorch/core/legacy/tools/eval…
ebbe26f 
…/tests/TestUtil.cpp +2

Summary: `numel()` has type `int64_t`. The implicit downcasts fix in this change artificially truncate data ranges which can lead to hard-to-debug errors and SEVs. Using `auto` ensures that the correct data type is used.

Reviewed By: dtolnay

Differential Revision: D73533979
@r-barnes r-barnes requested a review from tarun292 as a code owner April 23, 2025 23:10
@pytorch-bot
Copy link

pytorch-bot bot commented Apr 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10420

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit ebbe26f with merge base 954f2cb (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 23, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Apr 23, 2025

This pull request was exported from Phabricator. Differential Revision: D73533979

@github-actions
Copy link

github-actions bot commented Apr 23, 2025

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@github-actions
Copy link

github-actions bot commented Sep 1, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Sep 1, 2025
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarun292 tarun292 Awaiting requested review from tarun292

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale PRs inactive for over 60 days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@r-barnes @facebook-github-bot