Skip to content

Conversation

@mansnils
Copy link
Collaborator

@mansnils mansnils commented May 2, 2025

Adds SDPA decomposition and since SDPA is decomposed to safe_softmax instead of regular softmax, softmax decomposition is updated to handle safe_softmax.

Co-authored-by: Per Åstrand [email protected]
Co-authored-by: Måns Nilsson [email protected]

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Adds SDPA decomposition and since SDPA is decomposed to safe_softmax
instead of regular softmax, softmax decomposition is updated to handle safe_softmax.

Co-authored-by: Per Åstrand <[email protected]>
Co-authored-by: Måns Nilsson <[email protected]>

Change-Id: I384034fee8bd372d224e438adef5d3b0d1ec3ee3
@mansnils mansnils added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels May 2, 2025
@mansnils mansnils requested a review from digantdesai as a code owner May 2, 2025 14:36
@pytorch-bot
Copy link

pytorch-bot bot commented May 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10657

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 304fb38 with merge base 3ca6cbb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2025
@zingo zingo merged commit 7ba879d into pytorch:main May 2, 2025
174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants