From 39e848828b3fe1d5eeab46832ae4bff8bc6bc638 Mon Sep 17 00:00:00 2001 From: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com> Date: Fri, 9 May 2025 07:49:18 -0700 Subject: [PATCH] [ET-VK] Reducing memory wastage by tightening DescriptorPoolConfig values. This change replaces std::max(*descriptor_type_count*, max_sets) with *descriptor_type_count*, when creating DescriptorPoolConfig in ComputeGraph since Vulkan does not need to have at least one of each *descriptor_type_count* per set. Differential Revision: [D74452971](https://our.internmc.facebook.com/intern/diff/D74452971/) [ghstack-poisoned] --- backends/vulkan/runtime/graph/ComputeGraph.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/backends/vulkan/runtime/graph/ComputeGraph.cpp b/backends/vulkan/runtime/graph/ComputeGraph.cpp index 7fde7e04f91..31e03b9c7d2 100644 --- a/backends/vulkan/runtime/graph/ComputeGraph.cpp +++ b/backends/vulkan/runtime/graph/ComputeGraph.cpp @@ -594,13 +594,13 @@ void ComputeGraph::prepare() { prepack_descriptor_counts_.field) * \ config_.descriptor_pool_safety_factor)) - uint32_t max_sets = MERGE_FIELD(descriptor_pool_max_sets); - vkapi::DescriptorPoolConfig config{ + const uint32_t max_sets = MERGE_FIELD(descriptor_pool_max_sets); + const vkapi::DescriptorPoolConfig config{ max_sets, - std::max(MERGE_FIELD(descriptor_uniform_buffer_count), max_sets), - std::max(MERGE_FIELD(descriptor_storage_buffer_count), max_sets), - std::max(MERGE_FIELD(descriptor_combined_sampler_count), max_sets), - std::max(MERGE_FIELD(descriptor_storage_image_count), max_sets), + MERGE_FIELD(descriptor_uniform_buffer_count), + MERGE_FIELD(descriptor_storage_buffer_count), + MERGE_FIELD(descriptor_combined_sampler_count), + MERGE_FIELD(descriptor_storage_image_count), 1u, };